Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CVE-2020-7753] Update remark to 13.0.0 #1710

Merged
merged 4 commits into from Nov 10, 2020
Merged

[CVE-2020-7753] Update remark to 13.0.0 #1710

merged 4 commits into from Nov 10, 2020

Conversation

poteirard
Copy link
Contributor

Fixes #1706

@sapegin
Copy link
Member

sapegin commented Nov 6, 2020

Thanks for the pull request! Please have a look at the Travis CI results.

@poteirard
Copy link
Contributor Author

Fixed the emphasis tags. I asked in the remark repo how to have the auto links remarkjs/remark#560

sapegin
sapegin reviewed Nov 6, 2020
View reviewed changes
Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autolinking I think is actually undesirable and the new behavior is better. I found that even remove this behavior manually:

https://github.com/styleguidist/react-styleguidist/blob/master/src/loaders/utils/noAutoLinkRemarkPlugin.ts

So I think we probably can remove this file now.

src/loaders/utils/chunkify.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 6, 2020 •
edited

Codecov Report

Merging #1710 (5c9a2e7) into master (d80a190) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/loaders/utils/chunkify.ts 91.66% <100.00%> (ø)
src/loaders/utils/highlightCodeInMarkdown.ts 100.00% <100.00%> (ø)

@sapegin
Copy link
Member

sapegin commented Nov 7, 2020

Could you try to remove noAutoLinkRemarkPlugin.ts?

@poteirard
Copy link
Contributor Author

Removed noAutoLinkRemarkPlugin

@sapegin sapegin merged commit 2b7bfe2 into styleguidist:master Nov 10, 2020
@sapegin
Copy link
Member

sapegin commented Nov 10, 2020

Thanks!

@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 11.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Nov 10, 2020
Open
Open
Open
Open
@kopax kopax mentioned this pull request Feb 22, 2021
Open
This was referenced Mar 7, 2021
Open
Open
Open
This was referenced Mar 10, 2021
Open
Open
This was referenced Sep 15, 2021
Open
Open
Open
Open
@kopax kopax mentioned this pull request Dec 25, 2022
Open
@Yoasia1985 Yoasia1985 mentioned this pull request Dec 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 25, 2022
Open
This was referenced Dec 26, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapegin sapegin sapegin left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CVE-2020-7753] Update remark to 13.0.0
3 participants
@poteirard @sapegin @styleguidist-bot