Refactoring: simplify PropsRenderer a bit #206
Conversation
| return ( | ||
| <span>One of: <ul className={s.list}>{values}</ul></span> | ||
| <span> One of: <Group className={s.list} separator=", ">children={values}</Group></span> |
There was a problem hiding this comment.
This space wasn’t here. And this children= is something you probably forget to remove.
There was a problem hiding this comment.
Now we can remove CSS of old lists: .list and .listItem.
| )); | ||
|
|
||
| return ( | ||
| <span>One of type: <ul className={s.list}>{values}</ul></span> | ||
| <span>One of type: <Group className={s.list} seperator=", ">children{values}</Group></span> |
| @@ -5,7 +5,7 @@ | |||
| * @returns {string} | |||
| */ | |||
| export function unquote(string) { | |||
| return string.replace(/^\'|^\"|\"$|\'$/g, ''); | |||
| return string.replace(/^'|^"|"$|'$/g, ''); | |||
There was a problem hiding this comment.
This looks like some merge issue. Would you mind creating a new pull request? Or you could try to recreate your branch and push --force this branch if that would work.
There was a problem hiding this comment.
@sapegin The linting has issues with unnecessary escape characters
There was a problem hiding this comment.
I see, it was a warning, that’s why it didn’t break the CI.
|
If you remove all now unused CSS, I’ll be happy to merge it. |
| @@ -56,11 +57,10 @@ function renderDescription(prop) { | |||
| let { description } = prop; | |||
| let extra = renderExtra(prop); | |||
| return ( | |||
| <div> | |||
| <Group separator=" "> | |||
There was a problem hiding this comment.
Sorry, last few things: space is default separator, no need to specify it here.
There was a problem hiding this comment.
Thanks for the walk-through
| return ( | ||
| <span>One of: <ul className={s.list}>{values}</ul></span> | ||
| <span>One of: <Group separator=", ">{values}</Group></span> |
There was a problem hiding this comment.
Here and in the next one you need an inline option, otherwise it would be rendered on a separate line.
| @@ -136,6 +133,7 @@ function renderShape(props) { | |||
| return rows; | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
And this extra line wasn’t here.
|
Thank you very much!
|
* master: Update react-docgen. Update lint. Fix lint warning. Fix regression: colors in props table. Refactoring: simplify PropsRenderer a bit (#206) # Conflicts: # package.json
Fix regression introduced in #206.
This PR closes #194. It replaces li/ul tags with
react-grouppackage and simplifiesrenderDescription. The specs were fixed to reflect this changes.