fix(*): fix back button path for support pathname-relative paths #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapegin
reviewed
May 17, 2017
| @@ -88,7 +88,7 @@ export function ReactComponentRenderer({ | |||
| <div className={classes.pathLine}>{pathLine}</div> | |||
| <div className={classes.isolatedLink}> | |||
| {isolated | |||
| ? <Link href="/">← Back</Link> | |||
| ? <Link href="#">← Back</Link> | |||
There was a problem hiding this comment.
Will something like an empty string work to remove the # from the URL?
|
Thanks for the pull request! |
|
@sapegin , updated |
|
Cool, thanks! |
sapegin
added a commit
that referenced
this pull request
May 30, 2017
## New feature **Section isolated mode:** now you can open sections in isolated mode too. (#394 by @Knorcedger) ## Bug fixes * Fix React CodeMirror warning when opening code editor * Fix Create React App 1.0 support (#458) * Fix back button path for support pathname-relative paths (#447 by @stepancar) * Promise polyfill for IE11 because require.ensure requires it in webpack 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @sapegin.
Minor fix for situation when you docs published not in root of domain.
for example when your docs build at https://alfa-laboratory.github.io/arui-feather/arui-demo/styleguide url for isolated component is https://alfa-laboratory.github.io/arui-feather/arui-demo/styleguide/#!/Amount
"Back" button navigates to https://alfa-laboratory.github.io/