Passing codemirrorOptions as a configuration #649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
sapegin
requested changes
Oct 20, 2017
| @@ -39,6 +39,18 @@ module.exports = { | |||
| map: 'lodash/map', | |||
| }, | |||
| }, | |||
| codemirrorOptions: { | |||
| type: 'object', | |||
| default: { | |||
There was a problem hiding this comment.
This will be overwritten if codemirrorOptions isn’t undefined, we need to merge objects manually using process function.
| @@ -15,7 +15,7 @@ const filterComponentsWithExample = require('./utils/filterComponentsWithExample | |||
| // Config options that should be passed to the client | |||
| const CLIENT_CONFIG_OPTIONS = [ | |||
| 'title', | |||
| 'highlightTheme', | |||
| 'codemirrorOptions', | |||
There was a problem hiding this comment.
This is a breaking change, we should keep the old option until the next major release. See updateExample option in the config schema.
editorConfig would be a more generic name, and better match existing options like compilerConfig.
|
Hi Artem, unfortunately I can't spend more time on this issue for the time being. |
|
Closing in favor of #662. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.