Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prettier for .md files #709

Merged
merged 7 commits into from Dec 6, 2017
Merged

Conversation

leannaweller
Copy link
Contributor

fix #704

@sapegin
Copy link
Member

sapegin commented Nov 24, 2017

Looks like this Prettier issue is blocking this PR: prettier/prettier#3196

This doesn’t look good:

<Button>Push Me</Button>;

I was thinking about disabling semicolons in the docs but it has the opposite effect:

;<Button>Push Me</Button>

@sapegin
Copy link
Member

sapegin commented Nov 24, 2017

I’m not even sure if it’s a bug of a feature so let’s see what they think. In the worst case I’ll disable all JSX examples manually and merge it.

@sapegin
Copy link
Member

sapegin commented Nov 27, 2017

I’ve sent a PR to Prettier to fix that (it’s work in progress though), hope we could merge your PR soon!

@codecov-io
Copy link

codecov-io commented Dec 5, 2017

Codecov Report

Merging #709 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
scripts/utils/ensureWebpack.js 77.77% <ø> (ø) ⬆️
scripts/create-server.js 92.3% <100%> (ø) ⬆️
loaders/props-loader.js 97.14% <100%> (ø) ⬆️
...omponents/SectionHeading/SectionHeadingRenderer.js 100% <0%> (ø) ⬆️

@sapegin
Copy link
Member

sapegin commented Dec 5, 2017

I’ve updated Prettier, disabled semicolons and fixed several issues. Doc look good now. But we have to wait for another Prettier release with this fix: prettier/prettier#3401

@sapegin
Copy link
Member

sapegin commented Dec 6, 2017

I’ve updated Prettier again and now everything seems to work.

@sapegin sapegin merged commit 8155523 into styleguidist:master Dec 6, 2017
@sapegin
Copy link
Member

sapegin commented Dec 6, 2017

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format docs with Prettier
3 participants