Handle unknown proptypes #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I like the idea of displaying @sapegin: Merge? |
|
@mik01aj Good call. I was meant to go back and fix those up and completely forgot 👍 |
| @@ -11,6 +11,8 @@ export let Code = ({ className = '', children }) => { | |||
| return <code className={sMarkdown.code + ' ' + className}>{children}</code>; | |||
| }; | |||
|
|
|||
| export let UnknownPropType = () => <span>unknown</span>; | |||
There was a problem hiding this comment.
It is actually no longer required, have removed this now.
|
Just two comments from me, otherwise I really like this. Thanks @karlbright! |
|
All sorted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77.
This ensures that any prop that is assigned via
getDefaultPropsbut missing frompropTypeswill be shown as an unknown prop type.Although this is bad practice in React, I think it's probably best to display the style guide rather than throw and error for this, and ensure that the user can find out the explanation behind unknown proptypes in the styleguide readme.