Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "css" syntax option #177

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Support "css" syntax option #177

merged 1 commit into from
Oct 10, 2019

Conversation

hudochenkov
Copy link
Member

Which issue, if any, is this issue related to?

Fixes #155.

Is there anything in the PR that needs further explanation?

Currently blocked, because we need to release stylelint first. (11.0.1+).

@hudochenkov hudochenkov added the pr: blocked is blocked by another issue or pr label Oct 1, 2019
ntwb
ntwb approved these changes Oct 5, 2019
View reviewed changes
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, for when unblocked

@hudochenkov
Copy link
Member Author

Looks like I messed up somewhere in stylelint/stylelint#4315, because I get an error:

Cannot read property 'parse' of undefined

@hudochenkov hudochenkov mentioned this pull request Oct 10, 2019
Closed
4 tasks
@vankop
Copy link
Member

vankop commented Oct 10, 2019

Do you need any help?

@hudochenkov hudochenkov mentioned this pull request Oct 10, 2019
Merged
@hudochenkov
Copy link
Member Author

I made a fix stylelint/stylelint#4335

@hudochenkov hudochenkov removed the pr: blocked is blocked by another issue or pr label Oct 10, 2019
@hudochenkov hudochenkov merged commit 79e90e5 into master Oct 10, 2019
@hudochenkov hudochenkov deleted the add-css-option branch October 10, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb ntwb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sometimes warning for CSS syntax are not shown
3 participants
@hudochenkov @vankop @ntwb