Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "css" option to --syntax parameter #4315

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Add "css" option to --syntax parameter #4315

merged 1 commit into from
Oct 1, 2019

Conversation

hudochenkov
Copy link
Member

Which issue, if any, is this issue related to?

Needed to fix stylelint/stylelint-demo#155.

Is there anything in the PR that needs further explanation?

Currently there is no way to specify “css” syntax.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2019

Coverage Status

Coverage remained the same at 96.541% when pulling a816eab on add-css-syntax into 08467ae on master.

@ntwb
Copy link
Member

ntwb commented Oct 1, 2019

This will be a breaking change requiring a major release correct?

@alexander-akait
Copy link
Member

@ntwb no, should be as minor release

@hudochenkov
Copy link
Member Author

@ntwb it will be a minor version. We add new option, it doesn't change automatic syntax detection.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2019

Coverage Status

Coverage remained the same at 96.541% when pulling a816eab on add-css-syntax into 08467ae on master.

@hudochenkov hudochenkov merged commit 7b07ba8 into master Oct 1, 2019
@hudochenkov hudochenkov deleted the add-css-syntax branch October 1, 2019 11:31
@hudochenkov
Copy link
Member Author

  • Added: css syntax option (#4315).

@hudochenkov hudochenkov mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@vankop vankop vankop approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sometimes warning for CSS syntax are not shown
4 participants
@hudochenkov @ntwb @alexander-akait @vankop