Skip to content

Commit

Permalink
Update package-lock.json to lock file version 3
Browse files Browse the repository at this point in the history
  • Loading branch information
@romainmenke
romainmenke committed Jul 14, 2023
1 parent c1aefb4 commit 7aebaf5
Showing 1 changed file with 8,131 additions and 18,179 deletions.
Loading

5 comments on commit 7aebaf5

@romainmenke
Copy link
Member Author

@romainmenke romainmenke commented on 7aebaf5 Jul 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ybiquitous I had a typo that I missed when creating a new branch.
Hence the push to main.

I didn't expect this to be possible.
We have branch protection rules.
Why didn't these apply?

remote: Bypassed rule violations for refs/heads/main:
remote: 
remote: - Changes must be made through a pull request.
remote: 
remote: - 10 of 10 required status checks are expected.

It is quite stressful that this was able to go through 😅

@jeddy3
Copy link
Member

@jeddy3 jeddy3 commented on 7aebaf5 Jul 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romainmenke I suspect it's because you're in the Owners team, which lets you bypass the branch rules. There's an option we can turn on to disallow this. If I remember correctly, we didn't originally turn it on because we often pushed changelog entry commits after merging PRs. This isn't the case anymore as we use changesets.

Shall we turn the option on? Alternatively, we look into the new rulesets to see if it's worth migrating to them.

@romainmenke
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we turn the option on?

That would be nice, but if it makes regular flows and actions more complicated, it is also fine to remove me from the Owners teams :)
I suspect it will be rare that I need to do things that only Owners can and that no one else is around to help.

@jeddy3
Copy link
Member

@jeddy3 jeddy3 commented on 7aebaf5 Jul 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've turned the option on. (We can look into rulesets at a later date, if someone fancies it.)

@romainmenke
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇

Please sign in to comment.