Incorrect column reported by max-line-length

[m-allanson]

Describe the issue. Is it a bug or a feature request (new rule, new option, etc.)?

A bug where max-line-length will report an incorrect column number.

Which rule, if any, is this issue related to?

max-line-length

What CSS is needed to reproduce this issue?

a { background-image: url('some ignored url'); }

What stylelint configuration is needed to reproduce this issue?

{
  "rules": {
    "max-line-length": 20
  }
}

Which version of stylelint are you using?

7.7.1

(actually master@3183227, but I don't think that makes a difference)

How are you running stylelint: CLI, PostCSS plugin, Node API?

CLI

Does your issue relate to non-standard syntax (e.g. SCSS, nesting, etc.)?

No

What did you expect to happen?

A warning to be flagged, with the column indicating the end of the line:

test.css
1:48    Expected line length to be no more than 20 characters (max-line-length)

What actually happened (e.g. what warnings or errors you are getting)?

The following warning was flagged, listing an incorrect column number.

test.css
1:30    Expected line length to be no more than 20 characters (max-line-length)

---

Cause

The rule ignores long urls by replacing url('some ignored url') with url() before checking the line length.

If a line is still longer than the min length, the reported column number will be at the end of the line minus the url value:

a { background-image: url(); }

instead of the end of the line including the url value:

a { background-image: url('some ignored url'); }

Note that this bug is only triggered on lines that are still longer than max-line-length after the url value has been replaced.

---

Extra example

This issue can also cause errors to be reported on incorrect lines. The following CSS will report two errors on line 1, instead of an error on each line.

a { background-image: url('1234567890123456789012345678901234567890'); }
.foo .bar .baz .quux {}

 1:30  ✖  Expected line length to be no more than 20 characters   max-line-length
 1:54  ✖  Expected line length to be no more than 20 characters   max-line-length

[ntwb]

Fantastic sleuthing @m-allanson 👍

Can you add a test or tests for that code (or similar) you have in the Extra example above, it'd be great to ensure that that issue is also sorted in the resolution of this issue