Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate function-url-data-uris in favor of function-url-scheme-blacklist #2513

Closed
2 tasks done
alexander-akait opened this issue Apr 19, 2017 · 5 comments
Closed
2 tasks done
Assignees
Labels
status: wip is being worked on by someone type: enhancement a new feature that isn't related to rules
Milestone

Comments

@alexander-akait
Copy link
Member

alexander-akait commented Apr 19, 2017

  • Create function-url-scheme-blacklist
  • Deprecate function-url-data-uris

Describe the issue. Is it a bug or a feature request (new rule, new option, etc.)?

Deprecated function-url-data-uris in favor function-url-scheme-blacklist.

Which rule, if any, is this issue related to?

If i enable function-url-data-uris it is disable use data in url, but i can use function-url-scheme-whitelist without allowed data scheme and get two errors (intersection of rules). I think more right deprecated function-url-data-uris and add function-url-scheme-blacklist where i can disable data and maybe other scheme like as ftp, file and etc.

In now only function-url-scheme-whitelist don't have pair and it is should be function-url-scheme-blacklist.

What CSS is needed to reproduce this issue?

no matter

What stylelint configuration is needed to reproduce this issue?

no matter

Which version of stylelint are you using?

latest

How are you running stylelint: CLI, PostCSS plugin, Node API?

no matter

Does your issue relate to non-standard syntax (e.g. SCSS, nesting, etc.)?

no matter

What did you expect to happen?

no matter

What actually happened (e.g. what warnings or errors you are getting)?

no matter

/cc @stylelint/core

@alexander-akait alexander-akait added the status: needs discussion triage needs further discussion label Apr 19, 2017
@alexander-akait alexander-akait added this to the 8.0.0 milestone Apr 19, 2017
@davidtheclark
Copy link
Contributor

Sounds correct to me! 👩‍🚀

@alexander-akait
Copy link
Member Author

/cc @jeddy3 @hudochenkov what is your opinion?

@hudochenkov
Copy link
Member

Sounds right.

@jeddy3
Copy link
Member

jeddy3 commented Apr 23, 2017

Agreed. I was sure we were done with deprecations before 8.0.0, but it seems there will be a few more (e.g. the selector-max-* rules replacing the selector-no-* ones). As such, let's make sure we do this deprecation in a new deprecations-round-2 branch so that we can bundle them all into the same release to minimise inconvenience to the user.

@jeddy3 jeddy3 added status: ready to implement is ready to be worked on by someone type: enhancement a new feature that isn't related to rules and removed status: needs discussion triage needs further discussion labels Apr 23, 2017
@jeddy3 jeddy3 changed the title Deprecated function-url-data-uris in favor function-url-scheme-blacklist Deprecate function-url-data-uris in favor of function-url-scheme-blacklist Apr 23, 2017
@jeddy3 jeddy3 removed this from the 8.0.0 milestone Apr 23, 2017
@jeddy3 jeddy3 added this to the 7.12 milestone May 14, 2017
@jeddy3 jeddy3 added the good first issue is good for newcomers label May 14, 2017
@alexander-akait alexander-akait self-assigned this Jun 12, 2017
@alexander-akait alexander-akait added status: wip is being worked on by someone and removed good first issue is good for newcomers labels Jun 12, 2017
@jeddy3
Copy link
Member

jeddy3 commented Jun 26, 2017

FYI, I'm WIP on deprecating the old function-url-data-uris rule.

@jeddy3 jeddy3 removed the status: ready to implement is ready to be worked on by someone label Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip is being worked on by someone type: enhancement a new feature that isn't related to rules
Development

No branches or pull requests

4 participants