Fix isFirstNested util to handle shared-line comments
#2827
Conversation
| } | ||
| } | ||
|
|
||
| /* istanbul ignore next: Should always return in the loop */ |
There was a problem hiding this comment.
It's impossible for the code execution to reach here. One of the return statements in the for loop will always be executed. This is guaranteed because it returns if it finds the statement node in parent.nodes and that must happen because that node must be in its own parent's list of nodes.
If this is too strange I could change the return false; in the for loop into break; so then this return false; at the end of the function will be executed.
There was a problem hiding this comment.
@nwoltman good, just question, thanks!
There was a problem hiding this comment.
Why comment starts with “istanbul ignore next:”?
There was a problem hiding this comment.
Jest uses Istanbul for analyzing code coverage. That comment tells Istanbul not to count that line in the total code coverage since it's impossible to execute (the documentation is in the old Istanbul repo).
Fixes #2764
This changes the
isFirstNestedutil to ignore comments that are on the same line as the opening brace of a block when checking if the provided node is the first node in the block.