[#2829] add autofix for fix-shorthand-property-no-redundant-values #2956
Conversation
There was a problem hiding this comment.
Looks good, except few small things:
- Please, add
fix: truefor alltestRuleto be sure, we don't break style sheets unintentionally. - Add "(Autofixable)" for this rule in the rules list.
| result, | ||
| ruleName | ||
| }); | ||
| if (context.fix) { |
There was a problem hiding this comment.
Could you add an empty line before if for better readability, please?
| @@ -18,6 +18,8 @@ This rule alerts you when you use redundant values in the following shorthand pr | |||
| - `border-width` | |||
| - `grid-gap` | |||
|
|
|||
| The `--fix` option on the [command line](../../../docs/user-guide/cli.md#autofixing-errors) can automatically fix some of the problems reported by this rule. | |||
There was a problem hiding this comment.
can automatically fix some of the problems reported by this rule
Looks like it could fix all problems.
|
ok - addressed all the feedback. |
docs/user-guide/rules.md
Outdated
|
|
||
| #### String | ||
|
|
||
| - [`string-quotes`](../../lib/rules/string-quotes/README.md): Specify single or double quotes around strings. | ||
|
|
||
| #### Length | ||
|
|
||
| - [`length-zero-no-unit`](../../lib/rules/length-zero-no-unit/README.md): Disallow units for zero lengths. | ||
| - [`length-zero-no-unit`](../../lib/rules/length-zero-no-unit/README.md): Disallow units for zero lengths (Autofixable). |
There was a problem hiding this comment.
Not related to this PR. Addressed in #2957.
docs/user-guide/rules.md
Outdated
| - [`number-leading-zero`](../../lib/rules/number-leading-zero/README.md): Require or disallow a leading zero for fractional numbers less than 1. | ||
| - [`number-no-trailing-zeros`](../../lib/rules/number-no-trailing-zeros/README.md): Disallow trailing zeros in numbers. | ||
| - [`number-leading-zero`](../../lib/rules/number-leading-zero/README.md): Require or disallow a leading zero for fractional numbers less than 1 (Autofixable). | ||
| - [`number-no-trailing-zeros`](../../lib/rules/number-no-trailing-zeros/README.md): Disallow trailing zeros in numbers (Autofixable). |
There was a problem hiding this comment.
Not related to this PR. Addressed in #2957.
|
should be good now? |
@modosc Don't violate this rule! |
sorry about that. |
|
Retro-active review: Code LGTM! @modosc Thanks for adding the changelog item. Please remember to respect the conventions in the guide:
And then posting the changelog item into the thread. I've tweak it to:
|
|
@hudochenkov @jeddy3 thanks for bearing with me - i opened #2960 to clarify the approval process a bit. |
No worries at all. Many thanks for your continued work on stylelint. You've been nailing the autofix stuff recently :) |
#2829
No, it's self explanatory