New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: `media-feature-name-whitelist` and `media-feature-name-blacklist` now accept array as first option. #2632

Merged
merged 1 commit into from Jun 15, 2017

Conversation

3 participants
@evilebottnawi
Member

evilebottnawi commented Jun 13, 2017

Which issue, if any, is this issue related to?

#2536

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

Let's close all major bugs with new version and release patch version asap.

@hudochenkov @jeddy3

@jeddy3

jeddy3 requested changes Jun 13, 2017 edited

Thanks for this!

Can you tweak the config for the first test for each rule e.g. change this bit from:

config: [[ "max-width", "--wide-viewport", "width", "/^my-/", "color" ]],

To:

config: [ "max-width", "--wide-viewport", "width", "/^my-/", "color" ],

See function-whitelist for example.

This will help catch regressions.

Let's close all major bugs with new version and release patch version asap.

A patch release would be good!

@evilebottnawi evilebottnawi force-pushed the issue-2536 branch from 92cba7e to 201da0c Jun 13, 2017

@jeddy3

jeddy3 approved these changes Jun 13, 2017

Thanks! LGTM

@evilebottnawi

This comment has been minimized.

Member

evilebottnawi commented Jun 13, 2017

@jeddy3 jeddy3 merged commit 861a1bd into master Jun 15, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 95.489%
Details

@jeddy3 jeddy3 deleted the issue-2536 branch Jun 15, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 15, 2017

  • Fixed: media-feature-name-*list now accept arrays for their primary options (#2632).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment