Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test micromatch path.posix for Windows #2808

Closed
wants to merge 1 commit into from
Closed

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Aug 12, 2017

Per the comment micromatch/micromatch#95 (comment):

Maybe try using path.posix to ensure that posix slashes are always used when joining glob patterns.
const path = require("path").posix;

Tests pass locally here on macOS, let's see what AppVeyor has to say 馃

Supersedes #2753, see also #2691, #2597

@ntwb ntwb added status: wip is being worked on by someone type: infrastructure an improvement to devops labels Aug 12, 2017
@ntwb ntwb self-assigned this Aug 12, 2017
@ntwb
Copy link
Member Author

ntwb commented Aug 12, 2017

Closing, will research errors discovered in this PR and create a new PR

@ntwb ntwb closed this Aug 12, 2017
@ntwb ntwb deleted the path-posix-test branch August 12, 2017 08:39
@ntwb ntwb added resolution: invalid and removed status: wip is being worked on by someone type: infrastructure an improvement to devops labels Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant