Update micromatch to the latest version 🚀

[greenkeeper]

Version 3.0.0 of micromatch just got published.

Dependency	micromatch
Current Version	2.3.11
Type	dependency

The version 3.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of micromatch.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

---

Commits

The new version differs by 75 commits.

• e91c2f6 Merge pull request #76 from micromatch/dev
• 914059f run verb to generate readme
• c3bc209 add more unit tests
• 0f65651 lint
• 8d217f5 update benchmarks
• c013ef9 fix grammar
• ad97d84 Merge branch 'master' into dev
• cfeaa29 docs
• bf2cc5a fix url
• 0b679dc Merge pull request #88 from DianeLooney/master
• afd2312 Fixed the build badge
• d44afb5 adds examples
• c2e1e0b minor edits
• f2503bb move compose to main file
• e894de1 remove dead code, minor re-org

There are 75 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

---

Your Greenkeeper Bot 🌴

[greenkeeper]

Version 3.0.1 just got published.

Update to this version instead 🚀

Commits

The new version differs by 2 commits.

• 84a00c1 ensure options is a plain object
• 3b7ab15 3.0.0

See the full diff

[greenkeeper]

Version 3.0.2 just got published.

Update to this version instead 🚀

Commits

The new version differs by 5 commits.

• 6fb5555 3.0.2
• 5c700bb run verb to generate readme
• 7880461 closes micromatch/micromatch#91
• e47fc91 update examples
• e12fb36 3.0.1

See the full diff

[jonschlinkert]

just checking in to say thanks for using micromatch, and to offer our help if/when you decide to merge this in.

I see that some tests are failing, if micromatch 3.0.0 is indeed the cause, please stop by and let us know on the micromatch issues. thanks!

[hudochenkov]

@jonschlinkert thank you for offering your help! It will really help to understand what might go wrong if we'll have changelog for a new micromatch version.

[hudochenkov]

This test is failing.

And there we're using micromatch.

[ntwb]

The test, pasting here for reference:

it("createLinter().isPathIgnored", () => {
  const config = {
    ignoreFiles: [ "**/*.css", "!**/invalid-hex.css" ],
    rules: { "block-no-empty": true },
  }
  const linter = stylelint.createLinter({ config })

  return Promise.all([ linter.isPathIgnored("a.css"), linter.isPathIgnored("foo/bar/baz.css"), linter.isPathIgnored("foo/bar/baz.scss"), linter.isPathIgnored("foo/invalid-hex.css") ]).then(results => {
    expect(results).toEqual([ true, true, false, false ])
  })
})

The test results:

FAIL  lib/__tests__/createLinter.test.js
  ● createLinter().isPathIgnored
    expect(received).toEqual(expected)
    
    Expected value to equal:
      [true, true, false, false]
    Received:
      [true, true, true, false]
    
    Difference:
    
    - Expected
    + Received
    
     Array [
       true,
       true,
    +  true,
       false,
    -  false,
     ]
      
      at Promise.all.then.results (lib/__tests__/createLinter.test.js:35:21)

I believe our expected test results are accurate i that linter.isPathIgnored("foo/bar/baz.scss") should be false, the path foo/bar/baz.scss isn't included in the ignoreFiles config and as such it shouldn't be ignored and should not return true

[jonschlinkert]

it will really help to understand what might go wrong if we'll have changelog for a new micromatch version.

There shouldn't be any regressions. If there are it's unexpected.

pasting here for reference:

thanks, that helps!

[jonschlinkert]

@ntwb or @hudochenkov, if you have a moment could you re-run the tests on appveyor and travis? all tests are passing for me locally, and since npm was having server issues earlier I just want to make sure it's a bug before I dig in. thanks in advance

[ntwb]

@jonschlinkert I've just restarted all the CI jobs

[ntwb]

Looking like 2 out of 3 are passing, both Travis CI jobs are passing but not AppVeyor 🤔

[ntwb]

Actually the AppVeyor job has numerous failures:

https://ci.appveyor.com/project/stylelint/stylelint/build/4303#L886
https://ci.appveyor.com/project/stylelint/stylelint/build/4303#L1192
https://ci.appveyor.com/project/stylelint/stylelint/build/4303#L1256

Looks like maybe some incompatibility with globs and Windows?

[jonschlinkert]

Looks like maybe some incompatibility with globs and Windows?

well, "incompatibility" might be stretching it, there are 36,000 unit tests in micromatch with a great deal of attention focused on Windows paths. my guess is that the same bug is causing all of the failures here. Hopefully, that will be the case. I'll look into it ASAP and push up a fix. hopefully tomorrow

---

on a side note, I just pulled down stylelint and ran the tests on a Windows 8 machine locally (without upgrading micromatch), and here is what I'm getting:

none of these test failures are matching/globbing related. just thought you'd want to know.

[ntwb]

"...well, "incompatibility" might be stretching it"

My bad, sorry, not my best choice of words 😄

Thanks for the further info, will also take a closer look myself 👍

[jonschlinkert]

My bad, sorry, not my best choice of words

lol no worries. Btw I spent some time trying to debug yesterday. Is there a way to run a specific test? It takes 5-6 minutes for all the tests to run, which makes it difficult to re-run tests for just the failing ones. I'm not familiar enough with your test suite, any guidance on that would help. thanks

[hudochenkov]

Is there a way to run a specific test?

@jonschlinkert yes, run npm run watch, and then press p to filter by a filename regex pattern.

[jonschlinkert]

thanks. I just noticed that the appveyor tests are against micromatch 3.0.0, can you try to re-run it against the latest micromatch, v3.0.3? I'm not familiar with greenkeeper.

[hudochenkov]

@jonschlinkert restarted. Still has errors :(

Thank you for working on solution!

[jeddy3]

Superseded by #2691