Add selector-combinator-*list rules #3088

jeddy3 · 2017-12-29T15:06:17Z

hudochenkov

Good job!

Some things are controversial.

hudochenkov · 2017-12-29T19:44:35Z

lib/utils/__tests__/isStandardSyntaxCombinator.test.js

+    });
+  });
+  it("descendant (double child)", () => {
+    return rules("a >> b {}", func => {


I can't find it in a specification. Doesn't look like a standard one.

It's a level 4 one. I'll take it out though

hudochenkov · 2017-12-29T19:49:22Z

lib/rules/selector-combinator-blacklist/README.md

+```
+
+```css
+a >>> b {}


It's not a standard combinator. Maybe it's better not to add it to readme?

hudochenkov · 2017-12-29T19:50:26Z

lib/rules/selector-combinator-blacklist/index.js

+  return (root, result) => {
+    const validOptions = validateOptions(result, ruleName, {
+      actual: blacklist,
+      possible: [_.isString]


It should also check for _.isRegExp according to readme. It would be great to have RegExp in tests as well. Both as a string and as RegExp.

The same comment applies to the second rule.

hudochenkov · 2017-12-29T19:51:40Z

lib/rules/selector-combinator-blacklist/README.md

+
+## Options
+
+`array|string|regex`: `["array", "of", "unprefixed", "pseudo-elements" or "regex"]|"pseudo-element"|/regex/`


These rule about combinators.

hudochenkov · 2017-12-29T19:51:52Z

lib/rules/selector-combinator-whitelist/README.md

+
+## Options
+
+`array|string|regex`: `["array", "of", "unprefixed", "pseudo-elements" or "regex"]|"pseudo-element"|/regex/`


These rule about combinators.

hudochenkov · 2017-12-29T19:52:20Z

lib/rules/selector-combinator-whitelist/README.md

+```
+
+```css
+a >>> b {}


It's not a standard combinator. Maybe it's better not to add it to readme?

CAYdenberg

General points:

Can we add a couple tests for combinators without spaces and where " " is not specified as a combinator?

I'm thinking that POSSIBLY -whitelist should assume " " is a valid combinator and add it automatically to the config? As a user, it's so common that I'm not even sure I think about it. Could be a source of confusion resulting in bug reports we have to sift through later ... (this may go against the core values of stylelint and I'm good on it either way, just wanted to throw it out there ...)

I'm going to push back a bit on allowing RegExp's ... most combinators are just a single special character (+, ~) and I don't see this feature being all that useful. Puts cognitive load on the user and maintainers for possibly not much gain. I could be convinved otherwise, I just don't see a real use for it.

jeddy3 · 2018-01-01T11:13:11Z

I'm going to push back a bit on allowing RegExp's ... most combinators are just a single special character (+, ~) and I don't see this feature being all that useful.

That's a fair point. I originally intended to add RegExps for controlling what whitespace is allowed for descendant combinators. I've updated the tests and examples to show this, rather than use the child and piercing combinators.

I'm thinking that POSSIBLY -whitelist should assume " " is a valid combinator and add it automatically to the config?

I think there is a use case for not allowing the descendant combinator e.g. a completely flat specificity graph or when (exclusively) using CSS Modules' composes system.

Having said all that, perhaps it is better to split this up:

selector-descendant-combinator-no-non-space (already built)
selector-no-descendent-combinator
selector-combinator-blacklist
selector-combinator-whitelist

The latter two would ignore whitespace descendant combinators and not accept RegExp.

What do you think?

CAYdenberg · 2018-01-01T20:20:24Z

I think there is a use case for not allowing the descendant combinator e.g. a completely flat specificity graph or when (exclusively) using CSS Modules' composes system.

Fair. I'm sold on this the way it is. Having to create another rule and to handle an exception to this one seems like a waste. Maybe just make sure the README specifically mentions that " " is itself a combinator and needs to be whitelisted explicitly.

I originally intended to add RegExps for controlling what whitespace is allowed for descendant combinators.

Yeah, this seems like a different concern to me. Stylistic rather than functional.

jeddy3 · 2018-01-01T21:26:46Z

Ummm... I think you've (despite your conclusion) talked me out of not breaking the rule up.

Having to create another rule and to handle an exception to this one seems like a waste.

This rule is unique amongst the -*list rules because the decedent combinator itself isn't a simple string comparison. So, I think there's a case for splitting selector-no-descendent-combinator out and keeping the -*list rules consistent.

Yeah, this seems like a different concern to me. Stylistic rather than functional.

That's a good point. Keeping support for the descendant combinator in makes this rule half functional and half stylistic.

hudochenkov · 2018-01-03T21:36:14Z

I agree with @CAYdenberg. RegExp here might be redundant.

Yeah, this seems like a different concern to me. Stylistic rather than functional.

That's a good point. Keeping support for the descendant combinator in makes this rule half functional and half stylistic.

I believe these rules should be functional and not about the style of code.

To avoid using RegExp and avoid stylistic concerns we could replace /\s+/ in selectors with single space and do comparisons against normalized selector.

hudochenkov · 2018-01-03T21:29:42Z

lib/rules/selector-combinator-blacklist/README.md

+
+## Options
+
+`array|string|regex`: `["array", "of", "unprefixed", "combinators" or "regex"]|"combinator"|/regex/`


What are prefixed combinators? :)

jeddy3 · 2018-01-04T00:36:45Z

To avoid using RegExp and avoid stylistic concerns we could replace /\s+/ in selectors with single space and do comparisons against normalized selector.

That's a great idea. It does away with the need for the selector-no-descendent-combinator rule and can be easily communicated in the README.

I'll make the change now.

jeddy3 · 2018-01-04T01:03:09Z

@hudochenkov & @CAYdenberg This is ready for review again.

hudochenkov

Good job, @jeddy3!

Good catch on rule complexity and scope, @CAYdenberg!

hudochenkov · 2018-01-06T20:17:34Z

@CAYdenberg please, add a changelog item when PR merged https://github.com/stylelint/stylelint/blob/master/docs/developer-guide/pull-requests.md

CAYdenberg · 2018-01-06T20:24:43Z

I did ... just took a few extra minutes because I also have kids 🤕

hudochenkov · 2018-01-06T21:31:38Z

@CAYdenberg sorry, man. Saw you started answering other issues, and though you forgot. Sorry.

CAYdenberg · 2018-01-07T17:20:00Z

NP ... appreciate the respect for our process.

ntwb · 2018-01-08T00:57:30Z

Changelog: 741cd6e#diff-4ac32a78649ca5bdd8e0ba38b7006a1e

Added: selector-combinator-*list rules (#3088).

Add selector-combinator-*list rules

708806e

jeddy3 added the PR: review needed label Dec 29, 2017

hudochenkov reviewed Dec 29, 2017

View reviewed changes

CAYdenberg suggested changes Dec 31, 2017

View reviewed changes

Use whitespace regex in test and examples

14b7ff1

jeddy3 mentioned this pull request Jan 1, 2018

Reduce gatekeeping for (engine) contributions? #3093

Closed

ntwb mentioned this pull request Jan 3, 2018

Release 9.0.0 #3099

Closed

6 tasks

hudochenkov reviewed Jan 3, 2018

View reviewed changes

Normalise whitespace descendant combinator

aaf7e0e

hudochenkov approved these changes Jan 4, 2018

View reviewed changes

CAYdenberg approved these changes Jan 6, 2018

View reviewed changes

CAYdenberg merged commit 66f0ad6 into master Jan 6, 2018

CAYdenberg deleted the issue-3013 branch January 6, 2018 20:10

gucong3000 mentioned this pull request Jan 8, 2018

Remove PostCSS console warnings #3110

Merged

kaelig mentioned this pull request Feb 21, 2018

Upgrade for compatibility with stylelint 9.x.x Shopify/stylelint-config-shopify#26

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add selector-combinator-*list rules #3088

Add selector-combinator-*list rules #3088

jeddy3 commented Dec 29, 2017

hudochenkov left a comment

hudochenkov Dec 29, 2017

jeddy3 Jan 1, 2018

hudochenkov Dec 29, 2017

jeddy3 Jan 1, 2018

hudochenkov Dec 29, 2017

hudochenkov Dec 29, 2017

jeddy3 Jan 1, 2018

hudochenkov Dec 29, 2017

hudochenkov Dec 29, 2017

CAYdenberg left a comment

jeddy3 commented Jan 1, 2018 •

edited

CAYdenberg commented Jan 1, 2018

jeddy3 commented Jan 1, 2018 •

edited

hudochenkov commented Jan 3, 2018

hudochenkov Jan 3, 2018

jeddy3 commented Jan 4, 2018 •

edited

jeddy3 commented Jan 4, 2018

hudochenkov left a comment

hudochenkov commented Jan 6, 2018

CAYdenberg commented Jan 6, 2018

hudochenkov commented Jan 6, 2018

CAYdenberg commented Jan 7, 2018

ntwb commented Jan 8, 2018


		## Options

		`array\|string\|regex`: `["array", "of", "unprefixed", "pseudo-elements" or "regex"]\|"pseudo-element"\|/regex/`

Add selector-combinator-*list rules #3088

Add selector-combinator-*list rules #3088

Conversation

jeddy3 commented Dec 29, 2017

hudochenkov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CAYdenberg left a comment

Choose a reason for hiding this comment

jeddy3 commented Jan 1, 2018 • edited

CAYdenberg commented Jan 1, 2018

jeddy3 commented Jan 1, 2018 • edited

hudochenkov commented Jan 3, 2018

Choose a reason for hiding this comment

jeddy3 commented Jan 4, 2018 • edited

jeddy3 commented Jan 4, 2018

hudochenkov left a comment

Choose a reason for hiding this comment

hudochenkov commented Jan 6, 2018

CAYdenberg commented Jan 6, 2018

hudochenkov commented Jan 6, 2018

CAYdenberg commented Jan 7, 2018

ntwb commented Jan 8, 2018

jeddy3 commented Jan 1, 2018 •

edited

jeddy3 commented Jan 1, 2018 •

edited

jeddy3 commented Jan 4, 2018 •

edited