Add autofix to block-closing-brace-newline-after #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gucong3000
reviewed
Jul 21, 2018
| @@ -99,6 +99,22 @@ const rule = function(expectation, options) { | |||
| index: -1, | |||
| lineCheckStr: blockString(statement), | |||
| err: msg => { | |||
| if (context.fix) { | |||
| if (expectation.indexOf("always") === 0) { | |||
There was a problem hiding this comment.
Way not just use:
if (expectation === "always") {
There was a problem hiding this comment.
@gucong3000 It matches always, always-single-line, always-multi-line.
gucong3000
reviewed
Jul 21, 2018
| context.newline + nodeToCheck.raws.before; | ||
| } | ||
| return; | ||
| } else if (expectation.indexOf("never") === 0) { |
There was a problem hiding this comment.
Way not just use:
if (expectation === "never") {There was a problem hiding this comment.
@gucong3000 It matches never-single-line, never-multi-line.
jeddy3
changed the title
block-closing-brace-newline-after
jeddy3
approved these changes
Jul 21, 2018
|
This was referenced Jul 26, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. "Closes #000" or "None, as it's a documentation fix."
block-closing-brace-newline-afterin #2829e.g. "No, it's self explanatory."
ex.
option:
always***code:
fixed:
option:
never***code:
fixed: