Update to postcss-less@3

lib/rules/at-rule-blacklist/README.md

@@ -8,8 +8,6 @@ Specify a blacklist of disallowed at-rules.
  * At-rules like this */
 ```
 
-This rule ignores `@import` in Less.
-
 ## Options
 
 `array|string`: `["array", "of", "unprefixed", "at-rules"]|"at-rule"`

lib/rules/at-rule-blacklist/__tests__/index.js

@@ -160,16 +160,3 @@ testRule(rule, {
     }
   ]
 });
-
-testRule(rule, {
-  ruleName,
-  config: ["import"],
-  syntax: "less",
-
-  accept: [
-    {
-      code: "@import 'x.css';",
-      description: "ignore less @imports"
-    }
-  ]
-});

lib/rules/at-rule-empty-line-before/__tests__/index.js

@@ -1300,19 +1300,3 @@ testRule(
     ]
   })
 );
-
-testRule(rule, {
-  ruleName,
-  config: ["always"],
-  syntax: "less",
-
-  accept: [
-    {
-      code: stripIndent`
-      @media {}
-      @import 'x.css';
-    `,
-      description: "ignore less @imports"
-    }
-  ]
-});

lib/rules/at-rule-name-case/README.md

@@ -8,8 +8,6 @@ Specify lowercase or uppercase for at-rules names.
  * These at-rule names */
 ```
 
-This rule ignores `@import` in Less.
-
 Only lowercase at-rule names are valid in SCSS.
 
 The `--fix` option on the [command line](../../../docs/user-guide/cli.md#autofixing-errors) can automatically fix some of the problems reported by this rule.

lib/rules/at-rule-name-case/__tests__/index.js

@@ -284,16 +284,3 @@ testRule(rule, {
     }
   ]
 });
-
-testRule(rule, {
-  ruleName,
-  config: ["upper"],
-  syntax: "less",
-
-  accept: [
-    {
-      code: "@import 'x.css';",
-      description: "ignore less @imports"
-    }
-  ]
-});

lib/rules/at-rule-name-newline-after/README.md

@@ -9,8 +9,6 @@ Require a newline after at-rule names.
  * The newline after this at-rule name */
 ```
 
-This rule ignores `@import` in Less.
-
 ## Options
 
 `string`: `"always"|"always-multi-line"`

lib/rules/at-rule-name-newline-after/__tests__/index.js

@@ -402,16 +402,3 @@ testRule(rule, {
     }
   ]
 });
-
-testRule(rule, {
-  ruleName,
-  config: ["always"],
-  syntax: "less",
-
-  accept: [
-    {
-      code: "@import 'x.css';",
-      description: "ignore less @imports"
-    }
-  ]
-});

lib/rules/at-rule-name-space-after/README.md

@@ -8,8 +8,6 @@ Require a single space after at-rule names.
  * The space after at-rule names */
 ```
 
-This rule ignores `@import` in Less.
-
 The `--fix` option on the [command line](../../../docs/user-guide/cli.md#autofixing-errors) can automatically fix all of the problems reported by this rule.
 
 ## Options

lib/rules/at-rule-name-space-after/__tests__/index.js

@@ -469,16 +469,3 @@ testRule(rule, {
     }
   ]
 });
-
-testRule(rule, {
-  ruleName,
-  config: ["always"],
-  syntax: "less",
-
-  accept: [
-    {
-      code: "@import'x.css';",
-      description: "ignore less @imports"
-    }
-  ]
-});

lib/rules/at-rule-semicolon-newline-after/README.md

@@ -9,8 +9,6 @@ Require a newline after the semicolon of at-rules.
  * The newline after these semicolons */
 ```
 
-This rule ignores `@import` in Less.
-
 This rule allows an end-of-line comment followed by a newline. For example:
 
 ```css

lib/rules/at-rule-semicolon-newline-after/__tests__/index.js

@@ -125,15 +125,3 @@ testRule(rule, {
     }
   ]
 });
-
-testRule(rule, {
-  ruleName,
-  config: ["always"],
-  syntax: "less",
-  accept: [
-    {
-      code: "@import 'x.css';",
-      description: "ignore less @imports"
-    }
-  ]
-});

lib/rules/at-rule-semicolon-space-before/README.md

@@ -8,8 +8,6 @@ Require a single space or disallow whitespace before the semicolons at-rules.
  * The space before this semicolon */
 ```
 
-This rule ignores `@import` in Less.
-
 ## Options
 
 `string`: `"always"|"never"`

lib/rules/at-rule-semicolon-space-before/__tests__/index.js

@@ -151,16 +151,3 @@ testRule(rule, {
     }
   ]
 });
-
-testRule(rule, {
-  ruleName,
-  config: ["always"],
-  syntax: "less",
-
-  accept: [
-    {
-      code: "@import 'x.css';",
-      description: "ignore less @imports"
-    }
-  ]
-});

lib/rules/at-rule-whitelist/README.md

@@ -8,8 +8,6 @@ Specify a whitelist of allowed at-rules.
  * At-rules like this */
 ```
 
-This rule ignores `@import` in Less.
-
 ## Options
 
 `array|string`: `["array", "of", "unprefixed", "at-rules"]|"at-rule"`

lib/rules/at-rule-whitelist/__tests__/index.js

@@ -152,16 +152,3 @@ testRule(rule, {
     }
   ]
 });
-
-testRule(rule, {
-  ruleName,
-  config: ["media"],
-  syntax: "less",
-
-  accept: [
-    {
-      code: "@import 'x.css';",
-      description: "ignore less @imports"
-    }
-  ]
-});

lib/rules/function-url-quotes/README.md

@@ -8,8 +8,6 @@ a { background: url("x.jpg") }
  *             These quotes */
 ```
 
-This rule ignores `@import` in Less.
-
 ## Options
 
 `string`: `"always"|"never"`

lib/rules/function-url-quotes/__tests__/index.js

@@ -642,19 +642,6 @@ testRule(rule, {
   ]
 });
 
-testRule(rule, {
-  ruleName,
-  config: ["always"],
-  syntax: "less",
-
-  accept: [
-    {
-      code: "@import url(foo.css);",
-      description: "ignore less @imports"
-    }
-  ]
-});
-
 testRule(rule, {
   ruleName,
   config: ["always"],

lib/rules/no-duplicate-at-import-rules/README.md

@@ -9,8 +9,6 @@ Disallow duplicate `@import` rules within a stylesheet.
  * These are duplicates */
 ```
 
-This rule ignores `@import` in Less.
-
 ## Options
 
 ### `true`

lib/rules/no-extra-semicolons/index.js

@@ -2,6 +2,7 @@
 
 const eachRoot = require("../../utils/eachRoot");
 const isCustomPropertySet = require("../../utils/isCustomPropertySet");
+const isStandardSyntaxAtRule = require("../../utils/isStandardSyntaxAtRule");
 const isStandardSyntaxRule = require("../../utils/isStandardSyntaxRule");
 const report = require("../../utils/report");
 const ruleMessages = require("../../utils/ruleMessages");
@@ -75,6 +76,10 @@ const rule = function(actual, options, context) {
       }
 
       root.walk(node => {
+        if (node.type === "atrule" && !isStandardSyntaxAtRule(node)) {
+          return;
+        }
+
         if (
           node.type === "rule" &&
           !isCustomPropertySet(node) &&
@@ -150,9 +155,9 @@ const rule = function(actual, options, context) {
            */
           if (
             node.last &&
-            node.last.type === "rule" &&
+            node.last.type === "atrule" &&
             !isCustomPropertySet(node.last) &&
-            !isStandardSyntaxRule(node.last)
+            !isStandardSyntaxAtRule(node.last)
           ) {
             return;
           }

lib/rules/unit-case/__tests__/index.js

@@ -128,6 +128,10 @@ testRule(rule, {
     {
       code: "@media not screen and (min-width: 100px) {}",
       description: "negation @media"
+    },
+    {
+      code: "@import 'foo.css'",
+      description: "ignore non-media and non-variable at-rule"
     }
   ],
 

lib/rules/unit-case/index.js

@@ -60,9 +60,13 @@ const rule = function(expectation) {
       });
     }
 
-    root.walkAtRules(/^media$/i, atRule =>
-      check(atRule, atRule.params, atRuleParamIndex)
-    );
+    root.walkAtRules(atRule => {
+      if (!/^media$/i.test(atRule.name) && !atRule.variable) {
+        return;
+      }
+
+      check(atRule, atRule.params, atRuleParamIndex);
+    });
     root.walkDecls(decl => check(decl, decl.value, declarationValueIndex));
   };
 };

lib/rules/unit-no-unknown/__tests__/index.js

@@ -204,6 +204,10 @@ testRule(rule, {
     {
       code: "@media screen and (min-width:0\\0) {}",
       description: "ignore media query hack"
+    },
+    {
+      code: "@import 'foo.css'",
+      description: "ignore non-media and non-variable at-rule"
     }
   ],
 

lib/rules/unit-no-unknown/index.js

@@ -72,9 +72,13 @@ const rule = function(actual, options) {
       });
     }
 
-    root.walkAtRules(/^media$/i, atRule =>
-      check(atRule, atRule.params, atRuleParamIndex)
-    );
+    root.walkAtRules(atRule => {
+      if (!/^media$/i.test(atRule.name) && !atRule.variable) {
+        return;
+      }
+
+      check(atRule, atRule.params, atRuleParamIndex);
+    });
     root.walkDecls(decl => check(decl, decl.value, declarationValueIndex));
   };
 };

lib/utils/__tests__/isStandardSyntaxAtRule.test.js

@@ -94,6 +94,14 @@ describe("isStandardSyntaxAtRule", () => {
       expect(isStandardSyntaxAtRule(atRule)).toBeFalsy();
     });
   });
+
+  it("ignore calling of mixins", () => {
+    const less = "a { .mixin(); }";
+
+    lessAtRules(less, atRule => {
+      expect(isStandardSyntaxAtRule(atRule)).toBeFalsy();
+    });
+  });
 });
 
 function atRules(css, cb) {

lib/utils/isStandardSyntaxAtRule.js

@@ -7,17 +7,21 @@
  * @param {atRule} postcss at-rule node
  * @return {boolean} If `true`, the declaration is standard
  */
-module.exports = function(atRule /*: postcss$atRule*/) /*: boolean*/ {
+module.exports = function(atRule /*: Object*/) /*: boolean*/ {
   // Ignore scss `@content` inside mixins
   if (!atRule.nodes && atRule.params === "") {
     return false;
   }
 
-  // Ignore detached ruleset `@detached-ruleset: { background: red; }; .top { @detached-ruleset(); }`
+  // Ignore Less mixins
+  if (atRule.mixin) {
+    return false;
+  }
+
+  // Ignore Less detached ruleset `@detached-ruleset: { background: red; }; .top { @detached-ruleset(); }`
   if (
-    !atRule.nodes &&
-    atRule.raws.afterName === "" &&
-    atRule.params[0] === "("
+    atRule.variable ||
+    (!atRule.nodes && atRule.raws.afterName === "" && atRule.params[0] === "(")
   ) {
     return false;
   }

package.json

@@ -65,7 +65,7 @@
     "postcss": "^7.0.0",
     "postcss-html": "^0.34.0",
     "postcss-jsx": "^0.34.0",
-    "postcss-less": "^2.0.0",
+    "postcss-less": "^3.0.1",
     "postcss-markdown": "^0.34.0",
     "postcss-media-query-parser": "^0.2.3",
     "postcss-reporter": "^6.0.0",