Update to postcss-less@3 #3687

jwilsson · 2018-09-22T15:40:01Z

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

The biggest change is probably the removal of Import nodes from postcss-less, they will now always be a usual AtRule node. I've removed tests and doc notes around that.

Otherwise, it should be pretty straightforward. I've left some inline notes too.

jwilsson · 2018-09-22T15:41:03Z

lib/rules/unit-case/index.js

-      check(atRule, atRule.params, atRuleParamIndex)
-    );
+    root.walkAtRules(atRule => {
+      if (!/^media$/i.test(atRule.name) && !atRule.variable) {


There were a bunch of tests for @variable syntax, hence this change even though it's non-standard syntax. Perhaps those tests should be updated instead?

jwilsson · 2018-09-22T15:41:13Z

lib/rules/unit-no-unknown/index.js

-      check(atRule, atRule.params, atRuleParamIndex)
-    );
+    root.walkAtRules(atRule => {
+      if (!/^media$/i.test(atRule.name) && !atRule.variable) {


Same as above, there were a bunch of tests for @variable syntax, hence this change even though it's non-standard syntax. Perhaps those tests should be updated instead?

jwilsson · 2018-09-22T15:41:30Z

lib/utils/isStandardSyntaxAtRule.js

@@ -7,17 +7,21 @@
 * @param {atRule} postcss at-rule node
 * @return {boolean} If `true`, the declaration is standard
 */
-module.exports = function(atRule /*: postcss$atRule*/) /*: boolean*/ {
+module.exports = function(atRule /*: Object*/) /*: boolean*/ {


Perhaps someone better than me at Flow can help out with this.

I have no clue about Flow, to be honest. Maybe new properties should be added to this lines?

stylelint/flow-typed/postcss.js

Lines 30 to 38 in 6f86f23

declare class postcss$atRule extends postcss$node {

name: string;

params: string;

raws: {

before?: string,

after?: string,

afterName?: string

};

}

@CAYdenberg Any chance you've got a spare moment to check on this Flow issue please?

ai · 2018-09-22T21:25:01Z

postcss-less used PostCSS 5, so updating postcss-less will be very cool @ntwb

hudochenkov

Thank you for picking this up!

no-extra-semicolons was changed. Maybe it needs new tests?

Please, add tests for isStandardSyntaxAtRule.

hudochenkov · 2018-09-22T23:08:28Z

lib/utils/isStandardSyntaxAtRule.js

@@ -7,17 +7,21 @@
 * @param {atRule} postcss at-rule node
 * @return {boolean} If `true`, the declaration is standard
 */
-module.exports = function(atRule /*: postcss$atRule*/) /*: boolean*/ {
+module.exports = function(atRule /*: Object*/) /*: boolean*/ {


I have no clue about Flow, to be honest. Maybe new properties should be added to this lines?

stylelint/flow-typed/postcss.js

Lines 30 to 38 in 6f86f23

declare class postcss$atRule extends postcss$node {

name: string;

params: string;

raws: {

before?: string,

after?: string,

afterName?: string

};

}

jwilsson · 2018-09-23T17:15:36Z

@ hudochenkov Thanks for the review! I've added a new test for isStandardSyntaxAtRule.

no-extra-semicolons should be fine with the current tests, there are a few for mixins where the node type where changed from Rule to AtRule.

jeddy3 · 2018-10-08T15:26:14Z

Is there anything blocking this PR or can we get it in?

jeddy3 · 2018-10-09T06:59:38Z

@hudochenkov Have your concerns been addressed?

postcss-less@3 no longer emits a Import node, it's regular AtRule nodes now

jeddy3 · 2018-10-15T12:27:49Z

I rebased this on master, but node 10 (but not node 8) is failing on appveyor:

FAIL lib/__tests__/ignore.test.js
  ● using ignoreFiles with input files that would cause a postcss syntax error › no-syntax-error.css found
    expect(received).not.toBe(expected) // Object.is equality
    Expected: -1
    Received: -1
      307 | 
      308 |   it("no-syntax-error.css found", () => {
    > 309 |     expect(results[0].source.indexOf("no-syntax-error.css")).not.toBe(-1);
          |                                                                  ^
      310 |   });
      311 | 
      312 |   it("no-syntax-error.css linted", () => {
      at Object.toBe (lib/__tests__/ignore.test.js:309:66)

Anyone got an idea why?

alexander-akait · 2018-10-15T12:48:23Z

@jeddy3 maybe -1 is string?

jeddy3 · 2018-10-16T14:25:35Z

@jwilsson Thanks for this! Sorry about the delay in getting it merged.

jwilsson commented Sep 22, 2018

View reviewed changes

hudochenkov requested changes Sep 22, 2018

View reviewed changes

hudochenkov added the PR: needs tests label Sep 22, 2018

jeddy3 mentioned this pull request Sep 24, 2018

Update postcss-less to the latest version 🚀 #3686

Closed

hudochenkov mentioned this pull request Sep 26, 2018

Update postcss-less to the latest version 🚀 #3695

Closed

jeddy3 mentioned this pull request Sep 28, 2018

Fix false positives for comments within selector lists in selector-type-case #3698

Closed

ntwb approved these changes Oct 9, 2018

View reviewed changes

jeddy3 force-pushed the postcss-less-3 branch from a256ac3 to 111fd91 Compare October 9, 2018 06:58

hudochenkov approved these changes Oct 9, 2018

View reviewed changes

jeddy3 mentioned this pull request Oct 9, 2018

Failing appveyor test #3712

Closed

jwilsson added 8 commits October 11, 2018 12:26

Update to postcss-less@3

7e43357

Remove outdated 'ignore less imports' tests

0b2637c

postcss-less@3 no longer emits a Import node, it's regular AtRule nodes now

Remove doc notes about @import in Less

8c51872

Fix Less variables in unit-no-unknown

0dc9fcf

Fix Less variables in unit-case

c88b938

Fix ignore of Less mixins in no-extra-semicolons

ac854e0

Ignore Less mixins in isStandardSyntaxAtRule

451dc46

Add Less mixin test to isStandardSyntaxAtRule

57cc636

jeddy3 force-pushed the postcss-less-3 branch from 111fd91 to 57cc636 Compare October 11, 2018 11:26

jeddy3 removed the PR: needs tests label Oct 11, 2018

jeddy3 merged commit 9878260 into master Oct 16, 2018

jeddy3 deleted the postcss-less-3 branch October 16, 2018 14:23

jeddy3 mentioned this pull request Oct 16, 2018

Fix false positives for Less dynamic functions in unit-no-unknown #3721

Closed

This was referenced Oct 28, 2018

Update stylelint in /packages/generator/app/templates from 9.6.0 to 9.7.0 JetBrains/ring-ui#469

Merged

Update 2 dependencies from npm JetBrains/ring-ui#470

Merged

EvHaus mentioned this pull request Oct 29, 2018

Fix regression for single line comments in Less #3754

Closed

snyk-bot mentioned this pull request Sep 23, 2019

[Snyk] Upgrade stylelint from 9.6.0 to 9.10.1 maxiplux/blueprint#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to postcss-less@3 #3687

Update to postcss-less@3 #3687

jwilsson commented Sep 22, 2018 •

edited

Loading

jwilsson Sep 22, 2018

jwilsson Sep 22, 2018

jwilsson Sep 22, 2018

hudochenkov Sep 22, 2018

ntwb Oct 9, 2018

ai commented Sep 22, 2018

hudochenkov left a comment

hudochenkov Sep 22, 2018

jwilsson commented Sep 23, 2018

jeddy3 commented Oct 8, 2018

jeddy3 commented Oct 9, 2018

jeddy3 commented Oct 15, 2018

alexander-akait commented Oct 15, 2018

jeddy3 commented Oct 16, 2018

	declare class postcss$atRule extends postcss$node {
	name: string;
	params: string;
	raws: {
	before?: string,
	after?: string,
	afterName?: string
	};
	}

Update to postcss-less@3 #3687

Update to postcss-less@3 #3687

Conversation

jwilsson commented Sep 22, 2018 • edited Loading

jwilsson Sep 22, 2018

Choose a reason for hiding this comment

jwilsson Sep 22, 2018

Choose a reason for hiding this comment

jwilsson Sep 22, 2018

Choose a reason for hiding this comment

hudochenkov Sep 22, 2018

Choose a reason for hiding this comment

ntwb Oct 9, 2018

Choose a reason for hiding this comment

ai commented Sep 22, 2018

hudochenkov left a comment

Choose a reason for hiding this comment

hudochenkov Sep 22, 2018

Choose a reason for hiding this comment

jwilsson commented Sep 23, 2018

jeddy3 commented Oct 8, 2018

jeddy3 commented Oct 9, 2018

jeddy3 commented Oct 15, 2018

alexander-akait commented Oct 15, 2018

jeddy3 commented Oct 16, 2018

jwilsson commented Sep 22, 2018 •

edited

Loading