Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] chore(update): postcss-selector-parser #3988

Closed
wants to merge 1 commit into from
Closed

[WIP] chore(update): postcss-selector-parser #3988

wants to merge 1 commit into from

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Mar 14, 2019 •
edited

Which issue, if any, is this issue related to?

update parser

Is there anything in the PR that needs further explanation?

Maybe refactor code base, in some places we can improve speed add more check or simplify code, but it is out of this PR

Very few problems

@alexander-akait alexander-akait force-pushed the chore-update-postcss-selector-parse branch from 6020d00 to c5f1822 Compare March 14, 2019 16:40
alexander-akait
alexander-akait commented Mar 14, 2019
View reviewed changes
lib/utils/isStandardSyntaxCombinator.js
node.type === "combinator" &&
!node.value.startsWith("/") &&
!node.value.endsWith("/")
);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need lodash, we already require node@6, so we can use this function

lib/rules/string-quotes/index.js
fixPositions.push(openIndex, closeIndex);
if (context.fix) {
selectorFixed = true;
attributeNode.quoteMark = correctQuote;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port from #3284

lib/rules/selector-pseudo-class-parentheses-space-inside/__tests__/index.js
message: messages.rejectedOpening,
line: 1,
column: 13
}
}*/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bug in parser, investigate

lib/rules/selector-descendant-combinator-no-non-space/__tests__/index.js Outdated
message: messages.rejected(" "),
line: 1,
column: 17
},
},*/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bug in parser, investigate

system-tests/005/__snapshots__/005.test.js.snap Outdated
"text": "Unexpected \\"

\\" (selector-descendant-combinator-no-non-space)",
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bug in parser, investigate

@alexander-akait
Copy link
Member Author

alexander-akait commented Mar 14, 2019 •
edited

Still buggy and very misleading in raws/spaces, we need fix it in postcss-value-parser, WIP

@alexander-akait alexander-akait force-pushed the chore-update-postcss-selector-parse branch 3 times, most recently from faf5287 to 2284cdc Compare March 14, 2019 18:05
@alexander-akait
Copy link
Member Author

Blocker postcss/postcss-selector-parser#189

@alexander-akait alexander-akait force-pushed the chore-update-postcss-selector-parse branch from 2284cdc to 7ae1c4e Compare March 18, 2019 17:29
@alexander-akait alexander-akait force-pushed the chore-update-postcss-selector-parse branch from 7ae1c4e to 6f9e42e Compare March 18, 2019 17:35
@jeddy3
Copy link
Member

jeddy3 commented Apr 2, 2019

@evilebottnawi Thanks for working on this!

Is this still blocked by postcss/postcss-selector-parser#189?

@alexander-akait
Copy link
Member Author

Yep blocked, we need again do major release for selector parser, I think it was done to end of month

@jeddy3
Copy link
Member

jeddy3 commented Apr 2, 2019

Yep blocked, we need again do major release for selector parser

Do you mean a major release of the selector parser or a major release of stylelint?

@alexander-akait
Copy link
Member Author

Major release parser

@jeddy3
Copy link
Member

jeddy3 commented Apr 4, 2019

Can we close #3861 in favour of this PR?

@alexander-akait
Copy link
Member Author

@jeddy3 yes

This was referenced Apr 7, 2019
Closed
Closed
@hudochenkov hudochenkov mentioned this pull request Jul 31, 2019
Closed
@hudochenkov hudochenkov mentioned this pull request Sep 5, 2019
Closed
@hudochenkov
Copy link
Member

@evilebottnawi what prevents us update to the latest version?

@alexander-akait
Copy link
Member Author

@hudochenkov need fix comment parsing, i don't have enough time to fix it, sorry, maybe in future

@hudochenkov
Copy link
Member

@evilebottnawi is this fix should be made in parser or in stylelint?

@alexander-akait
Copy link
Member Author

@hudochenkov parser

@ybiquitous ybiquitous mentioned this pull request Nov 12, 2019
Merged
@hudochenkov hudochenkov mentioned this pull request Dec 25, 2019
Merged
@hudochenkov hudochenkov added the pr: blocked is blocked by another issue or pr label Dec 28, 2019
@jeddy3 jeddy3 mentioned this pull request Feb 13, 2020
Merged
@jeddy3
Copy link
Member

jeddy3 commented Feb 13, 2020

Closed in favour of #4595

@jeddy3 jeddy3 closed this Feb 13, 2020
@jeddy3 jeddy3 deleted the chore-update-postcss-selector-parse branch February 13, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: blocked is blocked by another issue or pr
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @jeddy3 @hudochenkov