Update selector parser #4595
Merged
Update selector parser #4595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vankop
approved these changes
Feb 13, 2020
hudochenkov
reviewed
Feb 13, 2020
There was a problem hiding this comment.
Thanks, @jeddy3!
Could you take a look at few tiny requests, please?
| @@ -10,23 +10,5 @@ module.exports = function(node) { | |||
| // Ghost descendant combinators around reference combinators like `/deep/` | |||
| // postcss-selector-parser parsers references combinators as tag selectors surrounded | |||
There was a problem hiding this comment.
This comment shall be changed to match new parser.
lib/rules/string-quotes/index.js
Outdated
Comment on lines
84
to
85
| const needsCorrectEscape = attributeNode.value.indexOf(correctQuote) !== -1; | ||
| const needsOtherEscape = attributeNode.value.indexOf(erroneousQuote) !== -1; |
There was a problem hiding this comment.
A little bit of readability:
const needsCorrectEscape = attributeNode.value.includes(correctQuote);
const needsOtherEscape = attributeNode.value.includes(erroneousQuote);
lib/rules/string-quotes/index.js
Outdated
Comment on lines
110
to
111
| const needsCorrectEscape = attributeNode.value.indexOf(correctQuote) !== -1; | ||
| const needsOtherEscape = attributeNode.value.indexOf(erroneousQuote) !== -1; |
There was a problem hiding this comment.
const needsCorrectEscape = attributeNode.value.includes(correctQuote);
const needsOtherEscape = attributeNode.value.includes(erroneousQuote);
|
Good catches. I've made the changes. |
hudochenkov
approved these changes
Feb 13, 2020
|
Do you think we should mention in a changelog that some rules were downgraded? |
|
I think so. |
|
This was referenced Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References https://github.com/orgs/stylelint/teams/core/discussions/18
Replaces #3988
I've ported over the changes from #3988. We changed our formatting and moved to TS JS Docs from flow since we made the original pull request
I believe only two rules are affected by this update:
selector-descendant-combinator-no-non-spacewill now outright ignore selectors containing commentsselector-pseudo-class-parentheses-space-insidecan now longer autofix pseudo-classes that contain commentsI think these are minor limitations for the sake of updating. I've added a note to the READMEs of both these rules.
We have fixed some other bugs by updating the selector parser, e.g. the one in
selector-attribute-brackets-space-inside/__tests__/index.js. Things probably balance out in the end.I've skipped the affected tests.
It'd be great if we could get #4592 and #4591 approved and merged too so that the new workaround feature and related documentation changes are also released.