Add Github Actions for testing

[hudochenkov]

Which issue, if any, is this issue related to?

#4273

Is there anything in the PR that needs further explanation?

It's a mix of #4273 (comment) and what Github gives by default for a Node.js project.

It need more work to migrate all features from .travis.yml.

[hudochenkov]

I'm impressed by speed of Github CI. In 5m 18s it done 10 jobs (3 Node version * 3 OS + 1 lint job), while neither Appveyor (2 jobs) nor Travis (4 jobs) is done.

[hudochenkov]

There is currently a bug with a step name:

[hudochenkov]

[hudochenkov]

To-do:

• We want to run CI on PRs (created PR, push to PR, force push). On master. And on ^dependabot/.*$ branches.
  

  stylelint/.travis.yml

  Lines 6 to 9 in c69e098

  	branches:
  	only:
  	- master
  	- /^dependabot/.*$/

• Preferably to use the latest npm version for every OS/Node.js
  

  stylelint/.travis.yml

  Line 35 in c69e098

  - npm install -g npm@latest

• Add coveralls https://github.com/marketplace/actions/coveralls-github-action. We have it implemented like this for Travis, which doesn't work with Github Actions.

I don't know why we use following env:

stylelint/.travis.yml

Lines 30 to 32 in c69e098

	- node_js: '12'
	script: npm run jest -- --maxWorkers=2
	env: CI=tests 12

I don't know if we need this:

stylelint/.travis.yml

Lines 40 to 42 in c69e098

	notifications:
	webhooks:
	- https://webhooks.gitter.im/e/d763493612da45967361

@digitaljohn is it something you can help us?

[jeddy3]

We want to run CI on PRs (created PR, push to PR, force push). On master. And on

Yes, please.

Preferably to use the latest npm version for every OS/Node.js

Yep, we'll want this as we only support the latest npm version.

Add coveralls https://github.com/marketplace/actions/coveralls-github-action.

Nice

The Gitter hook can go. It's from a time when we used Gitter for support.

I can't remember what the following is for:

env: CI=tests 12 

What happens when it goes?

[hudochenkov]

I noticed that all Windows jobs doesn't run Jest for some reason :( Only npm install.

[vankop]

I noticed that all Windows jobs doesn't run Jest for some reason :( Only npm install.

Do you have any log?

[hudochenkov]

https://github.com/stylelint/stylelint/pull/4285/checks?check_run_id=224510457

[vankop]

Straightforward idea can you write npm install && npm run jest ?

[vankop]

• We want to run CI on PRs (created PR, push to PR, force push). On master. And on ^dependabot/.*$ branches.

on:
  push:
    branches:    
      - master               # Push events on master branch
      - 'dependabot/*'  # Push events on Dependabot branches
    paths:
      - '!*.md'
 pull_request:
   paths:
      - '!*.md'

Hope it is enough

[hudochenkov]

@vankop feel free to work in this branch :)

[hudochenkov]

I just realized that we don't use coveralls. We have it, but we have not badge or link in a readme. And to be honest, I don't to see comments like #4285 (comment) on Github and in my email. There are not helpful.

[hudochenkov]

About using latest npm for all builds: actions/setup-node#31. It might not work, but we could try.

[hudochenkov]

The last question to answer is to whether we need coveralls or not #4285 (comment). Other things are looking good! And we achieved everything we wanted and even more (like tests on macOS and Windows).

[hudochenkov]

One more question to decide what are we going to do with Travis and Appveyor? I don't want to have them running with Github Actions at the same time. We don't need them anymore. When config files removed, then we have this results:

I don't see a solution to keep using Travis and Appveyor for previously opened PRs, but not use them for future PRs and master. I propose disable them right before we merge this PR, and all previous PRs would need to be rebased on master. All PRs should be rebased anyway, because we changed formatting recently.

[hudochenkov]

Tests still randomly fail on this test:

But it's outside the scope of this PR. Restart helps.

[ntwb]

I don't see a solution to keep using Travis and Appveyor for previously opened PRs, but not use them for future PRs and master. I propose disable them right before we merge this PR, and all previous PRs would need to be rebased on master. All PRs should be rebased anyway, because we changed formatting recently.

Agreed 👍🏼

I'd like to keep coveralls if we can, I think its still a useful tool for us

[hudochenkov]

I'd like to keep coveralls if we can, I think its still a useful tool for us

If anyone uses it for stylelint? :) If not, then regardless of how useful it is, we can remove it.

[ntwb]

If anyone uses it for stylelint? :) If not, then regardless of how useful it is, we can remove it.

I do partially, so even though we no longer have the coveralls badge on the readme I pipe the results into the Slack channel, I think it may still be configured to report on PRs if a PR changes the coverage by more than 5%, I think its a good safeguard to keep track of any potential issues we may run into by granting commit to any user who contributes.

[hudochenkov]

Make sense. Is it possible to configure to not post a comment in every PR, but only after certain threshold?

[ntwb]

Make sense. Is it possible to configure to not post a comment in every PR, but only after certain threshold?

That's the current behaviour I belive, it will only post a comment if the coverage changes by ~5%

p.s I just noticed we've hit 7,005 GitHub stars ⭐

[hudochenkov]

This PR is ready for approvals :)

[jeddy3]

Great work everyone!

Looks fab to me.

[ntwb]

Awesome 👍🏼👍🏼