-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Actions for testing #4285
Conversation
These syntaxes which use indentation for logic 🤦
I'm impressed by speed of Github CI. In 5m 18s it done 10 jobs (3 Node version * 3 OS + 1 lint job), while neither Appveyor (2 jobs) nor Travis (4 jobs) is done. |
There is currently a bug with a step name: |
To-do:
I don't know why we use following Lines 30 to 32 in c69e098
I don't know if we need this: Lines 40 to 42 in c69e098
@digitaljohn is it something you can help us? |
Yes, please.
Yep, we'll want this as we only support the latest npm version.
Nice The Gitter hook can go. It's from a time when we used Gitter for support. I can't remember what the following is for:
What happens when it goes? |
I noticed that all Windows jobs doesn't run Jest for some reason :( Only |
Do you have any log? |
Straightforward idea can you write |
Hope it is enough |
@vankop feel free to work in this branch :) |
90fb8d6
to
303d42a
Compare
I just realized that we don't use coveralls. We have it, but we have not badge or link in a readme. And to be honest, I don't to see comments like #4285 (comment) on Github and in my email. There are not helpful. |
About using latest npm for all builds: actions/setup-node#31. It might not work, but we could try. |
The last question to answer is to whether we need coveralls or not #4285 (comment). Other things are looking good! And we achieved everything we wanted and even more (like tests on macOS and Windows). |
This reverts commit 03d11f4.
One more question to decide what are we going to do with Travis and Appveyor? I don't want to have them running with Github Actions at the same time. We don't need them anymore. When config files removed, then we have this results: I don't see a solution to keep using Travis and Appveyor for previously opened PRs, but not use them for future PRs and master. I propose disable them right before we merge this PR, and all previous PRs would need to be rebased on master. All PRs should be rebased anyway, because we changed formatting recently. |
Agreed 👍🏼 I'd like to keep coveralls if we can, I think its still a useful tool for us |
If anyone uses it for stylelint? :) If not, then regardless of how useful it is, we can remove it. |
I do partially, so even though we no longer have the coveralls badge on the readme I pipe the results into the Slack channel, I think it may still be configured to report on PRs if a PR changes the coverage by more than 5%, I think its a good safeguard to keep track of any potential issues we may run into by granting commit to any user who contributes. |
Make sense. Is it possible to configure to not post a comment in every PR, but only after certain threshold? |
That's the current behaviour I belive, it will only post a comment if the coverage changes by ~5% p.s I just noticed we've hit |
This reverts commit d48cf05.
This PR is ready for approvals :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work everyone!
Looks fab to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍🏼👍🏼
#4273
It's a mix of #4273 (comment) and what Github gives by default for a Node.js project.
It need more work to migrate all features from
.travis.yml
.