Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add :is to pseudo-class list. fixes #4236. #4321

Merged
merged 2 commits into from
Oct 9, 2019

Conversation

bkinnamon
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #4236

Is there anything in the PR that needs further explanation?

:is is still an experimental technology, but issue #4236 asked for a PR.

https://developer.mozilla.org/en-US/docs/Web/CSS/:is

@vankop
Copy link
Member

vankop commented Oct 2, 2019

Thanks for PR! Could you create test cases for that, please.

@bkinnamon
Copy link
Contributor Author

I'm not sure I've done this right. I'm new to pull requests and trying to get the feel for things. Did the test case commit come through?

@hudochenkov
Copy link
Member

hudochenkov commented Oct 2, 2019

I'll close and open this PR to try to kick in Github Actions. They didn't started for the last commit for some reason.

UPD: It worked!

@hudochenkov hudochenkov closed this Oct 2, 2019
@hudochenkov hudochenkov reopened this Oct 2, 2019
@hudochenkov hudochenkov merged commit b0821f6 into stylelint:master Oct 9, 2019
@hudochenkov
Copy link
Member

  • Fixed: selector-pseudo-class-no-unknown false positives for :is selector (#4321).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix false positives for :is selector in selector-pseudo-class-no-unknown
5 participants