Add no-confusing-arrow ESLint rule
#4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudochenkov
reviewed
Jan 6, 2020
|
Don't forget to add this in the upstream open PR if it gets merged |
|
@ntwb would you like to fix lint errors? :) |
hudochenkov
force-pushed
the
no-confusing-arrow
branch
from
0c7ea8d
to
22863c1
Compare
|
Is this ready for review? |
|
@jeddy3 yes. |
|
@ntwb can you fix this? Otherwise we might as well drop the patch. |
|
Ah, wait, it seems @hudochenkov fixed it. Is there anything block from merging? For what is worth, I personally don't see any value in this rule. |
|
Shall we close this so that we can merge #4453? |
|
Why close and not merge? |
|
Merge works for me too :) |
hudochenkov
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4453 (comment)
e.g. "No, it's self explanatory."
The issues detected by the addition of this rule will require updating