Fix husky configuration and remove needless packages #5196
Conversation
package.json
Outdated
| @@ -38,25 +38,18 @@ | |||
| "scripts": { | |||
| "benchmark-rule": "node scripts/benchmark-rule.js", | |||
| "format": "prettier . --write", | |||
| "postinstall": "is-ci || husky install", | |||
| "prepare": "husky install", | |||
There was a problem hiding this comment.
[note] The husky document uses prepare instead of postinstall:
https://typicode.github.io/husky/#/?id=install
There was a problem hiding this comment.
Do we still need to do something to disable hooks on the CI?
Perhaps:
# .husky/pre-commit
# ...
[ -n "$CI" ] && exit 0
There was a problem hiding this comment.
Good catch! Fixed via 57eeb86.
I think we now don't need the CI check for the prepare script via is-ci:
{
"scripts": {
"prepare": "is-ci || husky install"
}
}If we would need it in the future, then let's install it again.
| "hooks": { | ||
| "pre-commit": "lint-staged" | ||
| } | ||
| }, |
There was a problem hiding this comment.
[note] This is an old configuration.
`husky` no longer requires `pinst` and `is-ci` since v5.1.2. (see <typicode/husky@84be675>) So, this change simplifies the `husky` configuration and removes the needless packages. See also <https://typicode.github.io/husky>.
|
There is so much hustle with |
|
@hudochenkov Honestly, I also don't like husky v5 so much... 😓 |
If none of the limitations are an issue for us, then I say go for it. |
|
|
|
Thank you for the feedback! 😄 |
huskyno longer requirespinstandis-cisince v5.1.2.(see typicode/husky@84be675)
So, this change simplifies the
huskyconfiguration and removes the needless packages.See also https://typicode.github.io/husky.
None.
None.