-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix end positions for at-rule-*-list
#6032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattxwang Thanks, LGTM 👍🏼
IMO, it's easier to understand if each rule message includes @
, e.g.
- Unexpected at-rule "foo"
+ Unexpected at-rule "@foo"
uses `name` instead of `atRule.name` Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@@ -47,6 +47,7 @@ const rule = (primary) => { | |||
node: atRule, | |||
result, | |||
ruleName, | |||
word: `@${atRule.name}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this also can be simplified: 😅
word: `@${atRule.name}`, | |
word: `@${name}`, |
at-rule-allowed-list
, at-rule-disallowed-list
at-rule-*-list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
|
Part of the umbrella issue #5694.
I modelled my approach off of #6026 - though, I did note that for the rule in that PR (
at-rule-no-unknown
), themessage
includes the@
, while for the rules in this PR, themessage
does not. I've still included the@
in the word itself; let me know if I should instead be consistent with themessage
.(also not sure about the add/fix terminology for the PR title, feel free to change if needed)