Refactor value parsing to use a simpler algorithm #6931
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None, it's a minor code quality fix that I noticed while working on a different issue.
This isn't a user facing change, so I am omitting a changelog entry.
parseCommaSeparatedListOfComponentValues
:rgb(0, 0, 0)
)parseListOfComponentValues
:TokenNode
This distinction is important when writing specialized parsers (like the media query parser) but it isn't relevant when validating component values.
Using
parseListOfComponentValues
results in simpler, cleaner code.The diffs appear large because the indent changed.
Actual diff :