-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to remove word
from the object passed to rangeBy
in report
util
#7781
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small questions :)
Thanks!
word
from the object passed to rangeBy
in report
utilword
from the object passed to rangeBy
in report
util
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #7779
This PR
index
would shift the search for the needle when used withword
As an aside, we have legitimate cases where passing just
node
is simpler than passing let's saynode
+word
.e.g. if we have to take into account the last semicolon
i.e. we cannot be as strict as not allowing passing
word
or at least it won't be covered by that PR