Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to remove word from the object passed to rangeBy in report util #7781

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

Mouvedia
Copy link
Member

Which issue, if any, is this issue related to?

Closes #7779

Is there anything in the PR that needs further explanation?

This PR

  1. revert this change
-rangeBy({ index, endIndex })
+rangeBy({ index, endIndex, word })
  1. addresses the recent changes that assumed that index would shift the search for the needle when used with word

As an aside, we have legitimate cases where passing just node is simpler than passing let's say node+word.
e.g. if we have to take into account the last semicolon
i.e. we cannot be as strict as not allowing passing word or at least it won't be covered by that PR

Copy link

changeset-bot bot commented Jun 21, 2024

⚠️ No Changeset found

Latest commit: 1f41bfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small questions :)
Thanks!

lib/rules/no-invalid-double-slash-comments/index.mjs Outdated Show resolved Hide resolved
lib/rules/selector-no-vendor-prefix/index.mjs Outdated Show resolved Hide resolved
@ybiquitous ybiquitous changed the title Remove word from the object passed to rangeBy in report util Refactor to remove word from the object passed to rangeBy in report util Jun 21, 2024
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍🏼

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mouvedia Mouvedia merged commit e675ac7 into stylelint:main Jun 21, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Address potentially breaking changes in #7769
3 participants