Skip to content

Commit

Permalink
feat: Bump vscode language server dependencies (#521)
Browse files Browse the repository at this point in the history
The vscode language server dependencies in this extension is 2 major
versions behind. There were important changes [between v7 and v8](https://github.com/microsoft/vscode-languageserver-node?tab=readme-ov-file#3170-protocol-800-json-rpc-800-client-and-800-server).

* Updated utilities that now return void promises
* Added a `deactivate` function to the extension to which is now
  recommended practice
* Replace `onReady` with `onStart` as described in the changelog
* Make the log function types more resilient - the `RemoteConsole`
  contains functions that are not just log functions.

Lots of reports have recently reported that 'stylelint does nothing' -
running the extension in debug mode to break on unhandled excpetions,
it's easy to see that there is client protocol changes since headers are
malformed in many requests.
  • Loading branch information
ling1726 committed Mar 22, 2024
1 parent fafb23f commit 23f0aef
Show file tree
Hide file tree
Showing 14 changed files with 340 additions and 119 deletions.
1 change: 1 addition & 0 deletions cspell.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const config = {
'uinteger',
'vscodeignore',
'Xerus',
'Supertypes',
],
overrides: [
{
Expand Down
145 changes: 94 additions & 51 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -208,12 +208,12 @@
"semver": "^7.3.5",
"serialize-error": "^8.1.0",
"triple-beam": "^1.3.0",
"vscode-languageclient": "^7.0.0",
"vscode-languageserver": "^7.0.0",
"vscode-languageserver-protocol": "^3.16.0",
"vscode-languageclient": "^9.0.1",
"vscode-languageserver": "^9.0.1",
"vscode-languageserver-protocol": "^3.17.5",
"vscode-languageserver-textdocument": "^1.0.11",
"vscode-languageserver-types": "^3.16.0",
"vscode-uri": "^3.0.2",
"vscode-languageserver-types": "^3.17.5",
"vscode-uri": "^3.0.8",
"winston": "^3.11.0",
"winston-transport": "^4.7.0"
},
Expand Down
Loading

0 comments on commit 23f0aef

Please sign in to comment.