-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump vscode language server dependencies #521
feat: Bump vscode language server dependencies #521
Conversation
The vscode language server dependencies in this extension is 2 major versions behind. There were important changes [between v7 and v8](https://github.com/microsoft/vscode-languageserver-node?tab=readme-ov-file#3170-protocol-800-json-rpc-800-client-and-800-server). * Updated utilities that now return void promises * Added a `deactivate` function to the extension to which is now recommended practice * Replace `onReady` with `onStart` as described in the changelog * Make the log function types more resilient - the `RemoteConsole` contains functions that are not just log functions. Lots of reports have recently reported that 'stylelint does nothing' - running the extension in debug mode to break on unhandled excpetions, it's easy to see that there is client protocol changes since headers are malformed in many requests. Fixes stylelint#498
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ling1726 Thank you for creating the pull request. And sorry for the late response.
So, can you fix the CI failures?
- Lint: this should be much easier.
- Test: this failure is due to coverage shortage of
deactivate()
. You can either add missing cases or just remove the function.
@ybiquitous I've fixed the lint issues and added test coverge so the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM 👍🏼
The vscode language server dependencies in this extension is 2 major versions behind. There were important changes between v7 and v8.
deactivate
function to the extension to which is now recommended practiceonReady
withonStart
as described in the changelogRemoteConsole
contains functions that are not just log functions.Lots of reports have recently reported that 'stylelint does nothing' - running the extension in debug mode to break on unhandled excpetions, it's easy to see that there is client protocol changes since headers are malformed in many requests.
I fixed unit tests errors and checked that integration/e2e tests pass
Fixes #498