typescript type definitions #339
Conversation
| children: React.ReactNode; | ||
| value: StandardEngine; | ||
| debugAfterHydration?: boolean; | ||
| debug?: any; |
There was a problem hiding this comment.
| debug?: any; | |
| debug?: BrowserDebugEngine | NoopDebugEngine; |
| } | ||
| export declare const Provider: typeof DevProvider | React.ProviderExoticComponent<React.ProviderProps<StandardEngine>>; | ||
| export declare function DevConsumer(props: { | ||
| children: (c: any, b: any, a: any) => React.ReactNode; |
There was a problem hiding this comment.
| children: (c: any, b: any, a: any) => React.ReactNode; | |
| children: ( | |
| styletronEngine: StandardEngine, | |
| debugEngine: BrowserDebugEngine | NoopDebugEngine, | |
| hydrating: boolean | |
| ) => React.ReactNode; |
that would be great to do this but, it is kind of outside of the scope of what I was doing - my goal was more about to convert as much of existing flow types as possible, and to reveal pain points in converted code by trying to do fixes needed after migration from flow(btw, I also have converted baseui codebase, to reveal what additional fixes in styletron needed to support usages in baseui). It was not really a goal to provide complete type coverage… and things which are however, if you feel like doing it - you can try doing it on top of ts branch (https://github.com/zxbodya/styletron/tree/ts) - I would be happy to update this pr to include those changes, also btw - it might be even better adding it as flow type annotations in sources (it is relatively easy to update ts version to include changes in flow sources) other option about doing it(which I am planning to try), would be to automate generating |
|
new PR based off this one: #371 |
While building a tool for flow to typescript migration, I used styletron as one of the projects to test it. And so - now I have typescript version of styletron(https://github.com/zxbodya/styletron/tree/ts)
Type definitions in this PR are generated from that typescript version.
While doing it, I was trying to make it compatible with definitions currently in DefinitelyTyped(ensuring things like type parameters order in generics to be the same), also I did some additional corrections while using it with migrated version of baseui
For the most part(except maybe some places where flow types were not very accurate) - new type definitions are more accurate comparing to the version in DefinitelyTyped.
btw, this should also help with #337