Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent change broke my app =( #125

Merged
merged 1 commit into from
Aug 21, 2012
Merged

Recent change broke my app =( #125

merged 1 commit into from
Aug 21, 2012

Conversation

caseywebdev
Copy link
Contributor

This reverts commit 0094b57.

These are still necessary! Latest Safari, Chrome, and Firefox still need prefixes...

tj added a commit that referenced this pull request Aug 21, 2012
Recent change broke my app =(
@tj tj merged commit dc8d37e into stylus:master Aug 21, 2012
@buschtoens
Copy link
Contributor

@caseywebdev Have you tried #118 before opening this issue?

#115 removes the obsolete (badly documented) syntax and enables the new one. We should not use the old syntax anymore, even if it seems to be broader supported at the moment. Nevertheless #115 tries to translate to the old syntax, so apps for old browsers don't break.

This is #115' + #118's support:
The translated new properties are:

  • align-items
  • flex
  • flex-basis
  • flex-direction
  • flex-flow
  • flex-grow
  • order

Untranslated new properties:

  • align-content
  • algin-self
  • flex-shrink
  • flex-wrap
  • justify-content

Obsolete properties that are now inaccessible:

  • box-flex-group
  • box-lines
  • box-pack

As long as you don't use box-flex-group, box-lines or box-pack, your app should look just fine with #118. #115 had some issues with expanding boxes, but #118 enables this feature. So please try #118 with your app and tell me if it works. Then #118 should be merged and devs should settle for the new syntax.

@visionmedia At the moment we have two syntaxes to accomplish an (almost) same result. When the new syntax gets standardised should we switch to the new one (which still partially translates to support older browsers) and deprecate the old one?

@caseywebdev
Copy link
Contributor Author

I wasn't aware of the new syntax, but I see what you mean. Changing

display box
box-align center
box-pack center

to

display flex
justify-content center
align-items center

Is now yielding the correct results. I'm +1 for #118, but I fear for everyone else who is going to run into this suddenly.

@buschtoens
Copy link
Contributor

Cool man! Thanks! :D
Yeah, you're right; people who are unaware of the new syntax will have a broken design. I thought about adding some ::before or ::after rules to notify users of the old syntax, that it's deprecated, but this is a little over the top.

It's up to @visionmedia, what we do.

@tj
Copy link
Collaborator

tj commented Aug 22, 2012

I dont know I dont have time to keep track of all these things haha, whatever actually works is a +1 from me

@buschtoens
Copy link
Contributor

Then it's #115 + #118 + #126. But brace yourself for a storm of "my app doesn't work" issues.

@tj
Copy link
Collaborator

tj commented Aug 22, 2012

haha well yeah that's why we should get it reasonably right the first time

kizu added a commit to kizu/nib that referenced this pull request Aug 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants