Preserving importance for everything #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…removed legacy vendor support from border-radiuses, as we dont support them for simple one
tj
added a commit
that referenced
this pull request
Aug 28, 2012
Preserving importance for everything
|
awesome! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat big thing!
displaylacked it, there was added support for display: xxx !important, display: box !important included #72, but it wasn't merged and I tried to give it a try myself. Also, it fixes (adds?) importance preserving to the border and border-radius helpers, so you could override them if you'd want.display, this thing won't break. Sometimes this importance thing can be really critical — you could have some global modifier class with some overrided important styles, and it would be a bummer if they won't override something after nib upgrade. So, I added some test to ensure the better future :)Yay for the tests!