Fix for issue #604 #763
Merged
Fix for issue #604 #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for issue #604 which caused stylus to crash when using --line-numbers or firebug and stein at the same time. This was caused by trying to call fs.realpathSync with a bogus file named stdin. https://github.com/LearnBoost/stylus/issues/604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #604 which caused stylus to crash when using
--line-numbers or firebug and stein at the same time. This was caused
by trying to call fs.realpathSync with a bogus file named stdin.
https://github.com/LearnBoost/stylus/issues/604
Obviously there is no path to include in the line numbers when using stdin, so I just used 'stdin' as the path name and prevented the call to fs.realpathSync which was causing the crash.