Updating some of the NEMO viscous solver routines. #1347
Conversation
|
This pull request fixes 1 alert when merging eab6dcd into f47e22b - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 210fefc into f47e22b - view on LGTM.com fixed alerts:
|
…o nemo_visc_update
|
This pull request fixes 1 alert when merging aceb911 into f47e22b - view on LGTM.com fixed alerts:
|
WallyMaier
changed the title
pcarruscag
changed the title
…o nemo_visc_update
WallyMaier
changed the title
|
This pull request fixes 1 alert when merging 9d086ab into 3ec1c68 - view on LGTM.com fixed alerts:
|
|
The versions you want are: |
|
@pcarruscag Thats interesting, I just crossed check the versions in my init.py file and they match the versions you posted. Im not sure what how to revert these changes :( |
|
checkout those commits I mentioned (by going inside externals/codi and externals/opdi) and then commit again and push |
|
This pull request fixes 1 alert when merging bc7aa7a into 3ec1c68 - view on LGTM.com fixed alerts:
|
|
Thanks! It looks like I needed to update a regression with change...strange. But its done. |
|
This pull request fixes 1 alert when merging 7a487f2 into 3ec1c68 - view on LGTM.com fixed alerts:
|
| @@ -96,7 +96,7 @@ void CIncNSSolver::Preprocessing(CGeometry *geometry, CSolver **solver_container | |||
| SetPrimitive_Limiter(geometry, config); | |||
| } | |||
|
|
|||
| ComputeVorticityAndStrainMag<1>(*config, iMesh); | |||
There was a problem hiding this comment.
What did the <1> here signify?
There was a problem hiding this comment.
It was part of a way to make a general function for all solvers. It is essentially VEL_INDEX
Proposed Changes
This PR updates some of the NEMO viscous routines to be more inline with the overall SU2 structure. Hopefully paving the way for an easier merge with turbulence solvers in the future.
Related Work
This is coming with an effort to update and optimize NEMO, like in #1343.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.