-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add look-up table class #1637
Add look-up table class #1637
Conversation
At this stage, I'd like to add only the functionality of reading and interpolating a lookuptable, without immediately implementing a combustion solver that uses it. |
This pull request introduces 1 alert when merging 1202a60 into 2ce680a - view on LGTM.com new alerts:
|
The test would go in UnitTests |
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
This pull request introduces 1 alert when merging c439501 into 6ca6ec2 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 9bb027f into 6ca6ec2 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 0b7fdb0 into da4c75d - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 7cb4919 into f15fe75 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 1b00541 into 7a57336 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging f4186f6 into ead83fe - view on LGTM.com new alerts:
|
CTrapezoidalMap::CTrapezoidalMap(vector<su2double> const& samples_x, vector<su2double> const& samples_y, | ||
vector<vector<unsigned long> > const& edges, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-format says this is OK. What would you like this to be? Every argument on a line when the list of arguments is too long? Would you like to see the behavior of:
BinPackParameters:false
If false, a function declaration’s or function definition’s parameters will either all be on the same line or will have one line each.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the const first, but if clang format doesn't complain it's fine I guess, even if not super consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that BinPackParameters:false does this (put const in front) as well, maybe we should add it to .clang-format?
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think I forgot yesterday, these files would be better in common/*/containers
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
…ss functions const
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
…into feature_lookuptable
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Adds the functionality of reading fluid data from an unstructured triangulated lookup table and interpolating. No coupling with a solver (combustion) yet, at this point we will only add a verification test
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
We split #1223 into smaller chunks
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.