Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVL/OpenVSP Matching #189

Merged
merged 7 commits into from Jul 31, 2017
Merged

AVL/OpenVSP Matching #189

merged 7 commits into from Jul 31, 2017

Conversation

timdmacdo
Copy link
Contributor

This modifies the AVL and OpenVSP scripts so that output matches for the cases where no wing segments and defined and all segments are defined. It also has a few bug fixes.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 45.159% when pulling 9ab7d44 on feature-AVL_OpenVSP_matching into 3b5e72b on develop.

@timdmacdo
Copy link
Contributor Author

I found another bug in how twist is assigned, will fix today.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 45.132% when pulling 3160ccc on feature-AVL_OpenVSP_matching into 3b5e72b on develop.

@timdmacdo
Copy link
Contributor Author

I've finished the fixes

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 45.132% when pulling 84c097b on feature-AVL_OpenVSP_matching into 3b5e72b on develop.

@planes
Copy link
Member

planes commented Jul 31, 2017

Looks good to me. It's annoying that coveralls says it's unsuccessful even if reduces coverage by 0.06 percent...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 45.132% when pulling 9e1547b on feature-AVL_OpenVSP_matching into 3b5e72b on develop.

@planes
Copy link
Member

planes commented Jul 31, 2017

I'll yank this in now.

@planes planes merged commit 337f6e8 into develop Jul 31, 2017
@mclarke2
Copy link
Member

I reviewed the geometry changes in the two scripts. They look fine to me

@planes planes deleted the feature-AVL_OpenVSP_matching branch August 15, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants