Skip to content
This repository has been archived by the owner on Oct 16, 2019. It is now read-only.

UI Bug in the Options Page #118

Closed
1 of 3 tasks
ghost opened this issue Mar 1, 2018 · 1 comment · Fixed by #164
Closed
1 of 3 tasks

UI Bug in the Options Page #118

ghost opened this issue Mar 1, 2018 · 1 comment · Fixed by #164

Comments

@ghost
Copy link

ghost commented Mar 1, 2018

This issue is a

  • bug
  • feature
  • question

Please describe the current behavior, and explain why it's bad.

In the options page, when adding files, the button stays on even if the permission is denied or if the prompt is closed. For File System upload and WebDAV, the button stays on but it says Disabled. In case of cloud storage, it opens the sign in page.
When such enabled button is disabled, the prompt appears again and if you allow permissions, the field becomes enabled.
Also, the sign in page is opened when enabling and disabling the button for the cloud storage fields.
Here's a video
https://youtu.be/iOJ0Kn8o8W8

Please describe how you think it should change.

When the permission is denied, button should stay disabled and in the case of cloud storage, the sign in page should not be opened.

Anything else?

just a UI bug, nothing serious.

  • Operating System: Windows 7 (64 bit)
  • Browsers:
  1. Chrome Version 64.0.3282.186
  2. Firefox Developer Edition: 59.0b13
@subdavis
Copy link
Owner

subdavis commented Mar 1, 2018

I've known about this for a while, just didn't prioritize the fix. Thanks for the official report!

zmilonas added a commit to zmilonas/Tusk that referenced this issue Jun 2, 2018
subdavis added a commit that referenced this issue Jun 3, 2018
Prevent default checked event to avoid the checkbox checking if user …
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant