Fix for object method calls no longer showing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: class-debug-bar-action-and-filters-addon.php debug-bar-action-and-filters-addon.php readme.txt
Also added two test files with example add_filter calls which should all work & be displayed.
subharanjanm
added a commit
that referenced
this pull request
Dec 19, 2013
Fix for object method calls no longer showing
|
Merged. Will update WordPress.Org plugin repository very soon. Thanks !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earlier closures fix actually caused a regression. Any callbacks given in array form, such as the below examples, were no longer showing in the filters list. As this is one of the most used (and advocated) forms in plugins, this effectively rendered the plugin nearly useless. This pull request fixes that.
The pull request is release ready, i.e. changelog has been updated, the version numbers have been upped and I've tested my changes in WP 3.6, 3.7 and 3.8.
Adiitionally I've added two test files with example
add_filter()calls which should all work & be displayed by the plugin. These do not have to be included in the actual plugin release, but are useful for testing of future changes to the filter list display function.