[HTML] don't indent after DOCTYPE, add indentation tests #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
force-pushed
the
html_doctype_indentation_fix
branch
from
5c0466c
to
264a1c5
Compare
|
Thanks! |
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some basic indentation tests for the HTML package, and prevents unexpected indentation from occurring after a
doctypedirective. This follows the PHP one, whereby we are only using the test file to make assertions about indentation, not scopes, to keep things simple. (IMO, it would be a fairly invasive style change to rework the existing syntax tests to also assert indentation doesn't change, so a separate test file keeps it neat and tidy.)EDIT: note that due to the presence of multi-line comments in the test file, we can only assert
reindent-unchangedand notreindent-unindenteddue to the defaultpreserveIndentbehavior as mentioned at sublimehq/sublime_text#1271 (comment)