[YAML] Don't match controversial plain bools in keys #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAML 1.1 made the prominent mistake of accepting many aliases for boolean values that many parsers adopted. For 1.2, these aliases have been removed, but for accuracy with the older version and especially considering how older parsers are still seeing use, we cannot simply remove matching them. However, the short names "y" and "on" are fairly common in keys and having those highlighted as a boolean is annoying, so we only match for the 1.2 scalars in keys.
deathaxe
approved these changes
Nov 10, 2020
|
Seems like a reasonable resolution, thanks @FichteFoll! |
deathaxe
added a commit
to deathaxe/PackageDev
that referenced
this pull request
Nov 20, 2020
FichteFoll
pushed a commit
to SublimeText/PackageDev
that referenced
this pull request
Nov 28, 2020
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
YAML 1.1 made the prominent mistake of accepting many aliases for boolean values that many parsers adopted. For 1.2, these aliases have been removed, but for accuracy with the older version and especially considering how older parsers are still seeing use, we cannot simply remove matching them. However, the short names "y" and "on" are fairly common in keys and having those highlighted as a boolean is annoying, so we only match for the 1.2 scalars in keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML 1.1 made the prominent mistake of accepting many aliases for boolean values that many parsers adopted. For 1.2, these aliases have been removed, but for accuracy with the older version and especially
considering how older parsers are still seeing use, we cannot simply remove matching them.
However, the short names "y" and "on" are fairly common in keys and having those highlighted as a boolean is annoying, so we only match for the 1.2 scalars in keys.
I believe this solution to be a satisfactory compromise for #1602, where this issue has been discussed at length.
Closes #1602.