Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ActionScript] Rename storage.type scope #2606

Merged

Conversation

deathaxe
Copy link
Collaborator

This commit replaces
a) storage.type.[class|function] by keyword.declaration.[class|function]
b) storage.modifier.extends by keyword.declaration.extends

This commit replaces
a) storage.type.[class|function] by keyword.declaration.[class|function]
b) storage.modifier.extends by keyword.declaration.extends
@wbond
Copy link
Member

wbond commented Nov 12, 2020

I'm not sure how I feel about changing extends/implements to a keyword.declaration. I don't think those are the same thing as class, def, var.

@deathaxe
Copy link
Collaborator Author

Renamed that as I used it in Java for some reason I don't recall anymore, but honestly got in doubt with it, too. storage.modifier may indeed be the better choice.

@wbond wbond merged commit 1218ebb into sublimehq:master Nov 12, 2020
@deathaxe deathaxe deleted the pr/action-script/only-keyword-declaration branch November 12, 2020 19:41
mitranim pushed a commit to mitranim/Packages that referenced this pull request Mar 25, 2022
This commit replaces storage.type.[class|function] by keyword.declaration.[class|function]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants