Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sublime Text Files syntax error flooding #1510

Open
evandrocoan opened this issue Nov 27, 2016 · 6 comments
Open

Sublime Text Files syntax error flooding #1510

evandrocoan opened this issue Nov 27, 2016 · 6 comments

Comments

@evandrocoan
Copy link

evandrocoan commented Nov 27, 2016

Sublime Text Files syntax error flooding

When there are several Sublime Text files within syntax error, and some of the is updated, all the errors are triggered and spam/flood the user with too much/senseless notice boxes. Those boxes are too much and senseless because:

  1. I am not gonna read them to inform myself about what was the error and where it is to fix it, as I cannot interact with Sublime Text to perform any actions.
  2. I am gonna have a hard time trying to close them because I cannot as Sublime Text do not let interact with Sublime Text to fix the error before they all to be closed.

bug

Steps to reproduce the error

Current Behavior

  1. Unzip this files to the Packages folder: Files.zip
  2. Immediately Sublime Text will flood you and you cannot do nothing beyond hitting the OK button, as you cannot read them to do the fix, due they being several and block interaction with Sublime Text.
  3. Open one of the Main.sublime-menu file and save it. All the error on the last step will be triggered again, not just the current saved file.

Expected behavior

  1. Unzip this files to the Packages folder: Files.zip
  2. Immediately Sublime Text will tell you to go to the console to see the list within all broken files, and Sublime Text will open the console for you was soon as you hit the OK button.
  3. Sublime text will not show me the above notice box before a minimum interval as 10 seconds.
  4. Now the user now it should see the console for the errors, and will be noticed again 10 seconds later by a new checkbox, if a save command is triggered by the user or some other event which trigger the current error message to be displayed is fired.

Sublime Text Build 3126

@FichteFoll
Copy link
Collaborator

I'm generally okay with errors for all files showing up when re-scanning resources, but ST should only open one message box with all of them instead of one for each.

@evandrocoan
Copy link
Author

Would be nice to print them to the console, as I often to forgot what it was, on which file and line. I do not think that to show only one notice box for them all would be good because Sublime Text would take longer to show the error as it would have to wait for the scanning to finish, and such process could take long.

A reasonable option is to show the first error and redirect the user to the console to seek for more, if they where found while the scanning is in progress. Once the scan finish and the user trigger a new scan by saving a file, the notice show box should be show again.

The notice box should not be show immediately if the scan was not triggers by the user saving a file because if the files system is constantly changing it would trigger new file scans and would keep spamming the notice boxes.

@FichteFoll
Copy link
Collaborator

FichteFoll commented Nov 27, 2016

All error messages are also printed to the console, unless I'm mistaken?

@evandrocoan
Copy link
Author

Actually they were, I didn't know it. So, would be welcome to tell it on the error message.

@Kristinita
Copy link

Similar behavior.

Thanks.

@evandrocoan
Copy link
Author

The issue #982 is a specif case of this for color schemes. This one, is emphasizing settings files. The general rule is the message dialog flood.

evandrocoan added a commit to evandrocoan/PackagesManager that referenced this issue Jun 16, 2017
there are error on them, we cannot show a error message dialog for
each one of them immediately, otherwise we would flood the user
with messages.

See:
Sublime Text Files syntax error flooding
sublimehq/sublime_text#1510
evandrocoan added a commit to evandrocoan/PackagesManager that referenced this issue Jun 16, 2017
there are error on them, we cannot show a error message dialog for
each one of them immediately, otherwise we would flood the user
with messages.

See:
Sublime Text Files syntax error flooding
sublimehq/sublime_text#1510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants