-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and pin mypy
and add CI
#87
Conversation
To be fair I don't really understand why old approach broke mypy. The link doesn't really explain this issue very well and even quick glance at mypy's code is not making it clear. @rwols @jfcherng @predragnikolic any idea? |
Looked at mypy's code a bit more and I think I understand it now. Mypy doesn't like when path in And https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-library-stubs-or-py-typed-marker explains why it behaves like that... |
The initial error is still there with those changes because the paths are still duplicated... This is so stupid, mypy shouldn't be complaining about that... |
Seems like the whole issue is just a regression in |
Will we close this PR because this is a regression in mypy? |
There are some useful bits here still and also I'm not sure if I should pin mypy version to resolve this issue for existing users... |
But I guess I will not go with bundling external types if I don't have to. |
* master: chore: bump pylsp-mypy from 0.6.2 to 0.6.3 (#88)
mypy
and add CI
Adding Sublime's Text own Python
Lib
directory broke mypy with an error like:Instead of including ST's Lib directory, bundle ST stubs.