-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove show_view_status setting? #722
Comments
Me, I like minimal UI :) But If you are interested,
Diagnostics messages are usually long, and can't fit in the status bar.
Can these two settings be combined?
I really don't know what this setting does?
|
I always use diagnostics via the status bar, using hover if I need more context. Some more settings that could be condensed/removed: I suspect not many people use prefer_label_over_filter_text, and we can probably remove the setting. quick_panel_monospace_font, show_references_in_quick_panel: can probably merge these into three "styles" for the references functionality: bottom-panel a la Visual Studio, quick-panel a la Sublime Text with or without monospace fonts. show_diagnostics_count_in_view_status: Doesn't the minimap already give a rough idea how many diagnostics there are? log_server: should we move towards implementing the |
|
|
@predragnikolik, @rwols and any other interested: Perhaps we can do another round of feedback on the proposals in the initial post above? We don't have to agree on all, but would be nice to close this issue with a few more quick wins! |
I use I would propose showing I am also in favor of moving the server logs to their own panel |
Agreed! This would also solve the mangled text when two threads are writing to the console (i.e. it would close #557). |
@ayoub-benali, what about servers that log to stderr? Should lines from window/showMessage, window/logMessage and stderr all go into the same panel? |
Metals logs
How about |
Sounds good, I'd like to have a go at an implementation :) |
Would be a good chance to try the sublime_lib OutputPanel, too! |
The easy cleanups are done, closing the issue but someone is welcome to start a pull request to evaluate the remaining proposals. |
As an effort of shrinking the package as we grow in other directions, I'd like to propose removing the
show_view_status
setting, showing the list of running language servers in the status bar, which is on by default.I understand that some people like to turn off "noise" in the UI, but anyone have this setting turned off ?
Discussed cleanups:
show_diagnostics_phantoms
REMOVEDprefer_label_over_filter_text
REMOVEDquick_panel_monospace_font
REMOVEDProposals:
show_view_status
: Create a single"ui": "minimal"
setting that hides all UI in status bar, phantoms, hovers that can be seen "on-request" instead (eg. no close/next/previous buttons on the phantoms, noshow_symbol_action_links
, no server names in status bar.)show_diagnostics_in_view_status
: I'd like to remove this as you can use the new diagnostic phantoms instead.auto_show_diagnostics_panel_level
andshow_diagnostics_severity_level
: We need to be able to showhint
andinfo
somewhere without the same urgency as errors and warnings. Is making one setting out of them worth the user pain / migration logic needed?That said looks likeFixed, regions/hovers on all diagnostics, panel and navigation respectshow_diagnostics_severity_level
is only used by the phantoms, not the panel or hover. I think VS Code had an interesting UI discussion about this.show_diagnostics_severity_level
. All that remains is removing thepanel_level
setting.The text was updated successfully, but these errors were encountered: