Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove registration of the legacy LanguageHandler class #1936

Merged
merged 7 commits into from Feb 15, 2022

Conversation

rwols
Copy link
Member

@rwols rwols commented Jan 18, 2022

I can't find any package any more that still uses this.

I can't find any package any more that still uses this.
@rwols rwols assigned rchl and predragnikolic and unassigned rchl and predragnikolic Jan 18, 2022
@predragnikolic
Copy link
Member

I guess only these 2 plugins that are published on PC still use LanguageHandler:

https://github.com/prometheus-community/sublimelsp-promql/blob/master/plugin.py#L130 (not part of the LSPSublimeOrg)
https://github.com/sublimelsp/LSP-Serenata/blob/master/plugin.py#L10

@predragnikolic
Copy link
Member

Will you also delete the /LSP/plugin/core/handlers.py file?

@jfcherng
Copy link
Contributor

jfcherng commented Jan 19, 2022

I guess only these 2 plugins that are published on PC still use LanguageHandler:

prometheus-community/sublimelsp-promql@master/plugin.py#L130 (not part of the LSPSublimeOrg) sublimelsp/LSP-Serenata@master/plugin.py#L10

LSP-Serenata hasn't updated for 2 years (still using an old server) and the server, Serenata was last active commit in 10 months ago. Consider PHP is evolving every year, I may assume both of LSP-Serenata and Serenata are gradually outdated...

Copy link
Member

@rchl rchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In boot.py those are unused:

  • import weakref
  • Callable and Tuple from .plugin.core.typing

Also maybe we should be defining __all__ to clearly indicate which imports are "public". That would also get rid of all false positive warnings that import is "unused".

@rwols rwols merged commit 5dfd068 into main Feb 15, 2022
@rwols rwols deleted the maintenance/remove-legacy-code branch February 15, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants