refactor handling of custom editor commands #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: fix "Error rewriting command" warning triggered on startup (#2277) Take font style of sighelp active parameter from color scheme (#2279) Add argument "include_declaration" to "lsp_symbol_references" (#2275) fix crash on checking excluded folders with missing project data (#2276) Fix tagged diagnostics flickering on document changes (#2274) Cut 1.24.0 use class for diagnostic info instead of hardcoding color (#2257) Fix package storage path in a docstring description (#2256) Use regular font style in sighelp popup if already highlighted by color scheme (#2259) update note about custom color scheme rule used for diagnostics (#2254)
rchl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the refactoring I did in #2249 into its own PR, without introducing handling for
editor.action.rename.The benefits are that the handling for
editor.action.triggerSuggestandeditor.action.triggerParameterHintsis supported in all contexts that runexecuteCommandand also those have access to the originating view instead of guessing.