Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to send the languageId in a didChange notification #459

Merged
merged 2 commits into from
Nov 10, 2018
Merged

No need to send the languageId in a didChange notification #459

merged 2 commits into from
Nov 10, 2018

Conversation

rwols
Copy link
Member

@rwols rwols commented Nov 9, 2018

See: https://microsoft.github.io/language-server-protocol/specification#textDocument_didChange

Compare: VersionedTextDocumentIdentifier (from didChange) versus TextDocumentItem (from didOpen)

@coveralls
Copy link

coveralls commented Nov 9, 2018 •
edited

Coverage Status

Coverage remained the same at 28.259% when pulling 243ca06 on bugfix/should-not-send-language-id-with-did-change into eb5e247 on master.

tomv564
tomv564 approved these changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@tomv564 tomv564 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@rwols rwols merged commit b0f0022 into master Nov 10, 2018
@rwols rwols deleted the bugfix/should-not-send-language-id-with-did-change branch November 10, 2018 11:28
@rwols rwols added this to the Release 0.8 milestone Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomv564 tomv564 tomv564 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rwols @coveralls @tomv564