Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for empty dict as completionProvider #652

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Account for empty dict as completionProvider #652

merged 2 commits into from
Jul 18, 2019

Conversation

rwols
Copy link
Member

@rwols rwols commented Jul 17, 2019

Related: #613

@coveralls
Copy link

coveralls commented Jul 17, 2019 •
edited

Coverage Status

Coverage remained the same at 37.928% when pulling 6e313ae on bugfix/empty-completionprovider-dict into c9a7390 on master.

@rwols rwols mentioned this pull request Jul 17, 2019
Closed
tomv564
tomv564 approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@tomv564 tomv564 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for documenting!

@tomv564 tomv564 merged commit 54755b4 into master Jul 18, 2019
@rwols rwols deleted the bugfix/empty-completionprovider-dict branch July 18, 2019 06:43
@rwols rwols mentioned this pull request Jul 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomv564 tomv564 tomv564 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rwols @coveralls @tomv564